Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets): add smithy-typescript to aws-sdk-js monorepo #33517

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TheHolyWaffle
Copy link
Contributor

@TheHolyWaffle TheHolyWaffle commented Jan 10, 2025

Changes

Add https://github.com/smithy-lang/smithy-typescript to the aws-sdk-js-v3 monorepo group

Context

Ref: #33507

I followed the same strategy as for the smithy-rs repository.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@TheHolyWaffle TheHolyWaffle changed the title Add smithy-typescript to aws-sdk-js monorepo feat(presets) Add smithy-typescript to aws-sdk-js monorepo Jan 10, 2025
@TheHolyWaffle TheHolyWaffle changed the title feat(presets) Add smithy-typescript to aws-sdk-js monorepo feat(presets): add smithy-typescript to aws-sdk-js monorepo Jan 10, 2025
"aws-sdk-js-v3": "https://github.com/aws/aws-sdk-js-v3",
"aws-sdk-js-v3": [
"https://github.com/aws/aws-sdk-js-v3",
"https://github.com/smithy-lang/smithy-typescript"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not right

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the suggested approach?

I followed the same strategy as with aws-sdk-rust monorepo:

    "aws-sdk-rust": [
      "https://github.com/smithy-lang/smithy-rs",
      "https://github.com/awslabs/smithy-rs",
      "https://github.com/awslabs/aws-sdk-rust"
    ],

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that was right either. I'll need to look through the history here. These don't seem to be monorepos, just related packages

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably should check all our monorepos and validate if they share same version or absolutely need to be grouped. we should remove all which don't share same version and don't need to be merged together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants