Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v18 / v19: Documentation for tag using property that is deprecated since v15 #17181

Closed
sandrotonon opened this issue Dec 23, 2024 · 1 comment
Closed

v18 / v19: Documentation for tag using property that is deprecated since v15 #17181

sandrotonon opened this issue Dec 23, 2024 · 1 comment
Labels
Component: Documentation Issue or pull request is related to Documentation

Comments

@sandrotonon
Copy link
Contributor

sandrotonon commented Dec 23, 2024 •
edited
Loading

Describe the bug

The documentation for PrimeNG 18.0.2 and 19.0.1 shows to use the icon property of p-tag to add an icon. However, this property has been deprecated since 15.4.2.

However, since the deprecation was removed from this property in PrimeNG version 17.18.14 (see #16220) i would also expect this to be removed in 18.0.X and 19.0.X.

Documentation
IntelliJ

v19:

primeng/packages/primeng/src/tag/tag.ts

Line 63 in 011989e

* @deprecated since 15.4.2. Use 'icon' template.

v18:

primeng/packages/primeng/src/tag/tag.ts

Line 63 in aaef4d9

* @deprecated since 15.4.2. Use 'icon' template.

Pull Request Link

v19: #17182

Reproducer

https://stackblitz.com/edit/github-kdxhm6nf?file=src%2Fapp%2Fapp.component.html

Environment

Irrelevant

Angular version

18.2.13

PrimeNG version

v18 (LTS Only)

Node version

20.14.0

Browser(s)

All

Steps to reproduce the behavior

No Response

Expected behavior

No Response
@sandrotonon sandrotonon added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 23, 2024
@sandrotonon sandrotonon changed the title Documentation for tag using property that is deprecated since v15 v18 / v19: Documentation for tag using property that is deprecated since v15 Dec 23, 2024
@mehmetcetin01140 mehmetcetin01140 added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 23, 2024
@mehmetcetin01140
Copy link
Contributor

Hi, the icon property is not deprecated, the documentation has been updated. Thank you for your feedback.

mehmetcetin01140 added a commit that referenced this issue Dec 23, 2024
@mehmetcetin01140
Fixed #17181 | v18 / v19: Documentation for tag using property that i…
56380a8 
…s deprecated since v15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sandrotonon @mehmetcetin01140