Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for tag using property that is deprecated since v15 #16220

Closed
jpgoelz opened this issue Aug 13, 2024 · 1 comment
Closed

Documentation for tag using property that is deprecated since v15 #16220

jpgoelz opened this issue Aug 13, 2024 · 1 comment
Assignees
@mehmetcetin01140
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone
17.18.14

Comments

@jpgoelz
Copy link

jpgoelz commented Aug 13, 2024

Describe the bug

The documentation for PrimeNG 17,18,8 shows to use the icon property of p-tag to add an icon. However, this property has been deprecated since 15.4.2.

The deprecation warning tells us how to replace this, but I think, the current documentation should reflect the correct way to use things. v15.4.2 came out over a year ago in May.

image

image

Environment

irrelevant

Reproducer

No response

Angular version

irrelevant

PrimeNG version

17.18.8

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

irrelevant

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@jpgoelz jpgoelz added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 13, 2024
@jpgoelz jpgoelz changed the title Documentation: Component: Tag using property that is deprecated since v15 Documentation for tag using property that is deprecated since v15 Aug 13, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 16, 2024
@mertsincan mertsincan added this to the 17.18.14 milestone Dec 16, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 16, 2024
mehmetcetin01140 added a commit that referenced this issue Dec 17, 2024
@mehmetcetin01140
Fixed #16220 | Documentation for tag using property that is deprecate…
dac4232 
…d since v15
@mehmetcetin01140
Copy link
Contributor

Hi, the icon property is not deprecated, the documentation has been updated. Thank you for your feedback.

@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Dec 17, 2024
This was referenced Dec 23, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
PrimeNG
Status: Done
Milestone
17.18.14
Development

No branches or pull requests
3 participants
@mertsincan @jpgoelz @mehmetcetin01140