Add file & note to README; add new var to agency.txt; misc text cleanup throughout #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Corrected remaining instances of "fare_rules_ft.txt" to reference "fare_periods_ft.txt" 2. Corrected variable names cited in text descriptions from "origin_zone" to "origin_id" (same for "destination_") 3. Fixed file links that were pointing to wrong level in directory tree 4. Changes to content of example tables under "Systemwide Fare" and "Inter-agency Fare..." to match what seems to be intended from the text
This file contains all possible edits to handle inconsistencies flagged in osplanning-data-standards#54. Once that is resolved, come back and review to confirm which changes stay/go. Then merge into patch-2 branch for big pull request back to osplanning-data-standards repo.
Field added in Feb-2016. See https://developers.google.com/transit/gtfs/reference/#agencytxt
Edits to address main repo Issue#54
|
Hi @e-lo -- Just wanted to make sure you saw this pull request...? (I forgot to tag you when I first submitted.) Some of these changes are reflected in the final T2 memo, so please let me know if you see anything amiss to make sure I can fix it in the deliverable, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two "structural" changes to the spec:
fare_attributes.txtat all, even though we include it in the repository. Added this file to table of optional files, with footnote below to clarify.agency_emailas an optional field inagency.txt; added this to GTFS-PLUS spec for consistency.Plus various edits throughout to address: