Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same handling for bikes & wheelchairs in vehicles_ft? #54

Open
ddorinson opened this issue May 28, 2018 · 2 comments
Open

Same handling for bikes & wheelchairs in vehicles_ft? #54

ddorinson opened this issue May 28, 2018 · 2 comments

Comments

@ddorinson
Copy link
Contributor

ddorinson commented May 28, 2018

Hi @danielsclint , @lmz ,@e-lo -- I am making a final pass to confirm that the T2 memo is consistent with the GTFS-PLUS repo, and I see a possible internal inconsistency within vehicles_ft.txt. Looking at the descriptions for wheelchair_capacity and bicycle_capacity in that file, it seems like they are set-up for parallel treatment, but they don't quite match:

  1. Only wheelchair_capacity explicitly says it will override the value "in trip file" (presumably trips.txt?). Is that also true for bicycle_capacity? (If not, should it be?)
  2. Only bicycle_capacity explains that a blank in this field should not be treated as infinity if the trip file specifies no bikes. Should wheelchair_capacity also be zero (not infinity) if trips.txt says wheelchairs cannot be accommodated?

Perhaps these differences are handled in the way the files are read in, but that doesn't seem like our usual M.O., and I couldn't find anything in the Fast-Trips code to confirm that the fields are actually treated any differently in the calcs. I would like to submit a pull request here in the GTFS-PLUS repo to clarify, but it should reflect how the code actually works, so wanted to double-check with you. Thoughts?

ddorinson added a commit to ddorinson/GTFS-PLUS that referenced this issue May 28, 2018
This file contains all possible edits to handle inconsistencies flagged in osplanning-data-standards#54.  Once that is resolved, come back and review to confirm which changes stay/go.  Then merge into patch-2 branch for big pull request back to osplanning-data-standards repo.
@e-lo
Copy link
Contributor

e-lo commented May 29, 2018

@ddorinson – Thanks for checking on this.
tl;dr I don't think we need to make any changes.

  • Not all of the definitions in GTFS-PLUS are handled explicitly in Fast-Trips, but I think we decided that we should still be explicit about what overrides what....so I think we are OK if Fast-Trips doesn't have a handler for these (for now).
  • Per ADA and general practice, wheelchairs are generally accommodated while bikes are generally not, so I think it is OK to have their blanks default to different values. In fact many operators will make others disembark in order to accommodate another wheelchair, so I the infinity default makes sense.
  • The reason why the wheelchair_capacity in vehicles_ft.txt is set up to override trips.txt is that wheelchair_capacity is contained in the official GTFS data standard, but it is more efficient to specify it at the vehicle- rather than trip-level. There is no field for bicycle capacity in the official GTFS trips.txt standard so specifying an override is moot.

@ddorinson
Copy link
Contributor Author

@e-lo -- Thanks for these details, which help fill in some of the gaps for me. For the record, I do not see wheelchair-capacity in the GTFS standard for trips.txt, only a wheelchair-accessible indicator variable with three options: 0=unknown; 1=1+ WC allowed; 2=no WC allowed. So the idea is that a blank in the wheelchair_capacity field in vehicles_ft.txt will override wheelchair-accessible=2 in trips.txt. In contrast, a blank field for bicycle_capacity in vehicles_ft.txt cannot override bicycles-allowed=2 in trips.txt. I will make sure the table in Appendix B reflects this approach. Thx again!

e-lo pushed a commit that referenced this issue Jun 12, 2018
…up throughout (#57)

* Cleanup names+intra-repo links; few table changes

1. Corrected remaining instances of "fare_rules_ft.txt" to reference "fare_periods_ft.txt"
2. Corrected variable names cited in text descriptions from "origin_zone" to "origin_id" (same for "destination_")
3. Fixed file links that were pointing to wrong level in directory tree
4. Changes to content of example tables under "Systemwide Fare" and "Inter-agency Fare..." to match what seems to be intended from the text

* Minor typo

* Minor typo

* Minor typos

* Minor typo

* Minor typos on last table row

* Edits to address main repo Issue#54

This file contains all possible edits to handle inconsistencies flagged in #54.  Once that is resolved, come back and review to confirm which changes stay/go.  Then merge into patch-2 branch for big pull request back to osplanning-data-standards repo.

* Clarify descriptions; fix table MD

* Add links to files w/in this repo

* Int -> Integer

* Add URL for ISO 639 codes

* Punctuation & capitalization

* Add optional "agency_email" per GTFS main spec

Field added in Feb-2016.  See https://developers.google.com/transit/gtfs/reference/#agencytxt

* Add "fare_attributes.txt" to optional files list

* Specify data type for cost variables

* Punctuation, file links, & other misc cleanup.

* Add footnote re: fare_attributes files

* One more URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants