-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Same handling for bikes & wheelchairs in vehicles_ft? #54
Comments
This file contains all possible edits to handle inconsistencies flagged in osplanning-data-standards#54. Once that is resolved, come back and review to confirm which changes stay/go. Then merge into patch-2 branch for big pull request back to osplanning-data-standards repo.
@ddorinson – Thanks for checking on this.
|
@e-lo -- Thanks for these details, which help fill in some of the gaps for me. For the record, I do not see wheelchair-capacity in the GTFS standard for |
…up throughout (#57) * Cleanup names+intra-repo links; few table changes 1. Corrected remaining instances of "fare_rules_ft.txt" to reference "fare_periods_ft.txt" 2. Corrected variable names cited in text descriptions from "origin_zone" to "origin_id" (same for "destination_") 3. Fixed file links that were pointing to wrong level in directory tree 4. Changes to content of example tables under "Systemwide Fare" and "Inter-agency Fare..." to match what seems to be intended from the text * Minor typo * Minor typo * Minor typos * Minor typo * Minor typos on last table row * Edits to address main repo Issue#54 This file contains all possible edits to handle inconsistencies flagged in #54. Once that is resolved, come back and review to confirm which changes stay/go. Then merge into patch-2 branch for big pull request back to osplanning-data-standards repo. * Clarify descriptions; fix table MD * Add links to files w/in this repo * Int -> Integer * Add URL for ISO 639 codes * Punctuation & capitalization * Add optional "agency_email" per GTFS main spec Field added in Feb-2016. See https://developers.google.com/transit/gtfs/reference/#agencytxt * Add "fare_attributes.txt" to optional files list * Specify data type for cost variables * Punctuation, file links, & other misc cleanup. * Add footnote re: fare_attributes files * One more URL
Hi @danielsclint , @lmz ,@e-lo -- I am making a final pass to confirm that the T2 memo is consistent with the GTFS-PLUS repo, and I see a possible internal inconsistency within vehicles_ft.txt. Looking at the descriptions for
wheelchair_capacity
andbicycle_capacity
in that file, it seems like they are set-up for parallel treatment, but they don't quite match:wheelchair_capacity
explicitly says it will override the value "in trip file" (presumably trips.txt?). Is that also true forbicycle_capacity
? (If not, should it be?)bicycle_capacity
explains that a blank in this field should not be treated as infinity if the trip file specifies no bikes. Shouldwheelchair_capacity
also be zero (not infinity) if trips.txt says wheelchairs cannot be accommodated?Perhaps these differences are handled in the way the files are read in, but that doesn't seem like our usual M.O., and I couldn't find anything in the Fast-Trips code to confirm that the fields are actually treated any differently in the calcs. I would like to submit a pull request here in the GTFS-PLUS repo to clarify, but it should reflect how the code actually works, so wanted to double-check with you. Thoughts?
The text was updated successfully, but these errors were encountered: