Fix typo in user_format: s/coma/comma/

app/models/concerns/reactable.rb

@@ -83,7 +83,7 @@ def user_name_concat_format_sql
         "users.firstname"
       when :lastname_firstname
         "concat_ws(' ', users.lastname, users.firstname)"
-      when :lastname_coma_firstname
+      when :lastname_comma_firstname
         "concat_ws(', ', users.lastname, users.firstname)"
       when :lastname_n_firstname
         "concat_ws('', users.lastname, users.firstname)"

app/models/principals/scopes/ordered_by_name.rb

@@ -57,7 +57,7 @@ def user_concat_sql
           "concat_ws(' ', users.firstname, users.lastname)"
         when :firstname
           "users.firstname"
-        when :lastname_firstname, :lastname_coma_firstname, :lastname_n_firstname
+        when :lastname_firstname, :lastname_comma_firstname, :lastname_n_firstname
           "concat_ws(' ', users.lastname, users.firstname)"
         when :username
           "users.login"

app/models/queries/filters/shared/user_name_filter.rb

@@ -71,7 +71,7 @@ def sql_concat_name
         "LOWER(CONCAT(users.firstname, ' ', users.lastname))"
       when :firstname
         "LOWER(users.firstname)"
-      when :lastname_firstname, :lastname_coma_firstname
+      when :lastname_firstname, :lastname_comma_firstname
         "LOWER(CONCAT(users.lastname, CONCAT(' ', users.firstname)))"
       when :lastname_n_firstname
         "LOWER(CONCAT(users.lastname, users.firstname))"

app/models/user.rb

@@ -36,7 +36,7 @@ class User < Principal
     firstname: [:firstname],
     lastname_firstname: %i[lastname firstname],
     lastname_n_firstname: %i[lastname firstname],
-    lastname_coma_firstname: %i[lastname firstname],
+    lastname_comma_firstname: %i[lastname firstname],
     username: [:login]
   }.freeze
 
@@ -295,7 +295,7 @@ def name(formatter = nil)
     when :firstname_lastname then "#{firstname} #{lastname}"
     when :lastname_firstname then "#{lastname} #{firstname}"
     when :lastname_n_firstname then "#{lastname}#{firstname}"
-    when :lastname_coma_firstname then "#{lastname}, #{firstname}"
+    when :lastname_comma_firstname then "#{lastname}, #{firstname}"
     when :firstname then firstname
     when :username then login
 

lib/api/decorators/sql/hal_associated_resource.rb

@@ -58,7 +58,7 @@ def associated_user_link_href(table_name, column_name)
 
           def associated_user_link_title(table_name)
             -> {
-              join_string = if Setting.user_format == :lastname_coma_firstname
+              join_string = if Setting.user_format == :lastname_comma_firstname
                               " || ', ' || "
                             else
                               " || ' ' || "

lib/api/v3/users/user_sql_representer.rb

@@ -39,7 +39,7 @@ def user_name_projection(*)
               "firstname"
             when :lastname_firstname
               "concat(lastname, ' ', firstname)"
-            when :lastname_coma_firstname
+            when :lastname_comma_firstname
               "concat(lastname, ', ', firstname)"
             when :lastname_n_firstname
               "concat_ws(lastname, '', firstname)"

spec/lib/api/v3/users/user_sql_representer_rendering_spec.rb

@@ -99,7 +99,7 @@
       it_behaves_like "name property depending on user format setting"
     end
 
-    context "when user_format is set to lastname_coma_firstname", with_settings: { user_format: :lastname_coma_firstname } do
+    context "when user_format is set to lastname_comma_firstname", with_settings: { user_format: :lastname_comma_firstname } do
       it_behaves_like "name property depending on user format setting"
     end
 

spec/mailers/user_mailer_spec.rb

@@ -125,7 +125,7 @@
     # and last name whereby an unescaped comma will lead to have two email addresses
     # defined instead of one (['Bobbi', '[email protected]'] vs. ['[email protected]'])
     context "with the user name setting prone to trip up email address separation",
-            with_settings: { user_format: :lastname_coma_firstname } do
+            with_settings: { user_format: :lastname_comma_firstname } do
       it_behaves_like "mail is sent"
     end
 

spec/models/concerns/reactable_spec.rb

@@ -159,7 +159,7 @@
       end
     end
 
-    context "when user format is set to :lastname_coma_firstname", with_settings: { user_format: :lastname_coma_firstname } do
+    context "when user format is set to :lastname_comma_firstname", with_settings: { user_format: :lastname_comma_firstname } do
       it "returns grouped emoji reactions with last coma firstname" do
         result = Journal.grouped_emoji_reactions(reactable_id: wp_journal1.id, reactable_type: "Journal")
 

spec/models/principal_spec.rb

@@ -135,7 +135,7 @@ def self.should_return_groups_and_users_if_active(method, *)
     shared_let(:placeholder_user_id) { create(:placeholder_user, name: "Wannabejohn").id }
 
     shared_examples "name formatting" do
-      context "for lastname_coma_firstname formatter", with_settings: { user_format: :lastname_coma_firstname } do
+      context "for lastname_comma_firstname formatter", with_settings: { user_format: :lastname_comma_firstname } do
         it "returns formatted user name" do
           expect(user.name).to eq "Smith, John"
         end

spec/models/principals/scopes/ordered_by_name_spec.rb

@@ -73,7 +73,7 @@
       end
     end
 
-    context "with lastname_coma_firstname user sort", with_settings: { user_format: :lastname_coma_firstname } do
+    context "with lastname_comma_firstname user sort", with_settings: { user_format: :lastname_comma_firstname } do
       it_behaves_like "sorted results" do
         let(:order) { [anonymous.id, eve.id, group.id, placeholder_user.id, alice.id] }
       end

spec/models/user_spec.rb

@@ -332,7 +332,7 @@
         it { is_expected.to eq "SmithJohn" }
       end
 
-      context "for lastname_coma_firstname", with_settings: { user_format: :lastname_coma_firstname } do
+      context "for lastname_comma_firstname", with_settings: { user_format: :lastname_comma_firstname } do
         it { is_expected.to eq "Smith, John" }
       end
 
@@ -350,8 +350,8 @@
 
       let(:user) { described_class.select_for_name(formatter).last }
 
-      context "for lastname_coma_firstname" do
-        let(:formatter) { :lastname_coma_firstname }
+      context "for lastname_comma_firstname" do
+        let(:formatter) { :lastname_comma_firstname }
 
         it { is_expected.to eq "Smith, John" }
       end