Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in user_format: s/coma/comma/ #17542

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Fix typo in user_format: s/coma/comma/ #17542

wants to merge 1 commit into from

Conversation

myabc
Copy link
Contributor

@myabc myabc commented Jan 7, 2025

Ticket

What are you trying to accomplish?

Screenshots

What approach did you choose and why?

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

ulferts
ulferts requested changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@ulferts ulferts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case someone has already selected that value it will be stored in the database as lastname_coma_firstname so will have to write a migration to change that value in there.

@myabc myabc force-pushed the fix/typo-user_format branch from 705f0c9 to b4c51d6 Compare January 8, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulferts ulferts ulferts requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@myabc @ulferts