Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[paymentservice] Fix transactionId in JSON response #230

Merged
merged 1 commit into from
Jul 25, 2022
Merged

[paymentservice] Fix transactionId in JSON response #230

merged 1 commit into from
Jul 25, 2022

Conversation

mic-max
Copy link
Contributor

@mic-max mic-max commented Jul 25, 2022 •
edited
Loading

Changes

Switch from transaction_id to transactionId
Fixes the payment service e2e test and also the

Replace the change in this closed PR #197 with simpler, more targeted fix.

Passing test screenshot
image

@mic-max mic-max requested a review from a team July 25, 2022 22:37
@mic-max mic-max mentioned this pull request Jul 25, 2022
Merged
cartersocha
cartersocha approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@cartersocha cartersocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cartersocha cartersocha merged commit 49ab768 into open-telemetry:main Jul 25, 2022
@mic-max mic-max deleted the payment-fix-txid branch July 26, 2022 18:41
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@mic-max
Fix transaction id in payment service (open-telemetry#230)
615672a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartersocha cartersocha cartersocha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mic-max @cartersocha