Recommendation service e2e testing #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianocosta89
previously requested changes
Jul 12, 2022
There was a problem hiding this comment.
I've tried the test and they failed in 4 out 5 tests, was that intended?
✖ payment: valid credit card Rejected promise returned by test
✖ payment: invalid credit card
✖ payment: amex credit card not allowed
✖ payment: expired credit card
✔ recommendation: list products
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
The payment service had an issue with it that I fixed in this PR which ill reduce to only the fix Update: heres the new PR fixing those tests #230 |
|
Got the following now: Are we expecting only |
Correct. The payment test failures were fixed in this PR |
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #195
Merge after: #196
(If anyone knows a good git workflow for creating a PR based off another one that hasn't yet been merged yet please let me know so I can make these PRs cleaner since this one include all the previous branches commits - all I did was
git checkout -b recc-service-testwhile on themic-max:e2e-testsbranch` anyways... shoot me a dm 😄)Changes
client.py, essentially a manual version of this testThe 1 test sends 5 product ids. this makes sure that the recommendation service always sends back the same array 4 product ids (random ordering) - it caps at 5 recommendations and wont include anything you sent in the request. I was originally going to test it just by including 1 id in the request but then its possible the service sends back 5 products that dont include the one in my request just by chance. So this way is more robust, still not perfect though since the random generator isn't seeded and more reasons I won't get into.