Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsconfig): highlight JS errors in editors for this project #14

Merged
merged 5 commits into from
May 11, 2021
Merged

feat(jsconfig): highlight JS errors in editors for this project #14

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fd61247
feat(jsconfig): highlight JS errors in editors for this project
oscard0m Mar 7, 2021
13a05c2
chore(jsconfig): add explanatory comment on why jsconfig.json is scaf…
oscard0m May 11, 2021
39e3119
ci(lint): run prettier for all mardkwon and json files
oscard0m May 11, 2021
dbcb692
style(jsconfig): run prettier
oscard0m May 11, 2021
03661f3
fix(package.json): add missing quotes to json and md patterns
oscard0m May 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions jsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"compilerOptions": {
"checkJs": true,
"module": "es2020",
"target": "es2020",
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you format with prettier?

We can update the lint scripts

create-octoherd-script/package.json

Lines 18 to 19 in cf9eb5e

"lint": "prettier --check 'lib/*.js' cli.js README.md package.json",
"lint:fix": "prettier --write 'lib/*.js' cli.js README.md package.json",

to update all *.json and *.md files in the root folder

I'm reluctant about adding config files as you know, but I think it's worth it in this case. I wish we could add a comment to explain why it is here for people who don't know. Do you know if jsconfig.json supports json5 by default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not support JSON5 and there are no plans for supporting it, but it supports JSONC which has comments too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you format with prettier?

We can update the lint scripts

create-octoherd-script/package.json

Lines 18 to 19 in cf9eb5e

"lint": "prettier --check 'lib/*.js' cli.js README.md package.json",
"lint:fix": "prettier --write 'lib/*.js' cli.js README.md package.json",

to update all *.json and *.md files in the root folder

could you address that please?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done