-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jsconfig): highlight JS errors in editors for this project #14
Conversation
jsconfig.json
Outdated
"module": "es2020", | ||
"target": "es2020", | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you format with prettier?
We can update the lint
scripts
create-octoherd-script/package.json
Lines 18 to 19 in cf9eb5e
"lint": "prettier --check 'lib/*.js' cli.js README.md package.json", | |
"lint:fix": "prettier --write 'lib/*.js' cli.js README.md package.json", |
to update all *.json
and *.md
files in the root folder
I'm reluctant about adding config files as you know, but I think it's worth it in this case. I wish we could add a comment to explain why it is here for people who don't know. Do you know if jsconfig.json
supports json5 by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not support JSON5 and there are no plans for supporting it, but it supports JSONC which has comments too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you format with prettier?
We can update the
lint
scriptscreate-octoherd-script/package.json
Lines 18 to 19 in cf9eb5e
"lint": "prettier --check 'lib/*.js' cli.js README.md package.json", "lint:fix": "prettier --write 'lib/*.js' cli.js README.md package.json", to update all
*.json
and*.md
files in the root folder
could you address that please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Co-authored-by: Gregor Martynus <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ππΌ
π This PR is included in version 1.4.0 π The release is available on: Your semantic-release bot π¦π |
π Summary
Add
jsconfig.json
to this projectβ± Motivation and Context
To highlight JS errors in this project and, bypass this error:
Fix #13
π How Has This Been Tested?
πΈ Screenshot Before
πΈ Screenshot After