Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsconfig): highlight JS errors in editors for this project #14

Merged
merged 5 commits into from
May 11, 2021

Conversation

oscard0m
Copy link
Member

@oscard0m oscard0m commented Mar 7, 2021

πŸ“ Summary

Add jsconfig.json to this project

β›± Motivation and Context

To highlight JS errors in this project and, bypass this error:
image

Fix #13

πŸ“Š How Has This Been Tested?

πŸ“Έ Screenshot Before

image

πŸ“Έ Screenshot After

image

@oscard0m oscard0m requested a review from gr2m March 7, 2021 14:59
jsconfig.json Outdated
"module": "es2020",
"target": "es2020",
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you format with prettier?

We can update the lint scripts

"lint": "prettier --check 'lib/*.js' cli.js README.md package.json",
"lint:fix": "prettier --write 'lib/*.js' cli.js README.md package.json",

to update all *.json and *.md files in the root folder

I'm reluctant about adding config files as you know, but I think it's worth it in this case. I wish we could add a comment to explain why it is here for people who don't know. Do you know if jsconfig.json supports json5 by default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not support JSON5 and there are no plans for supporting it, but it supports JSONC which has comments too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you format with prettier?

We can update the lint scripts

"lint": "prettier --check 'lib/*.js' cli.js README.md package.json",
"lint:fix": "prettier --write 'lib/*.js' cli.js README.md package.json",

to update all *.json and *.md files in the root folder

could you address that please?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@oscard0m oscard0m requested a review from gr2m May 11, 2021 16:14
package.json Outdated Show resolved Hide resolved
@oscard0m oscard0m requested a review from gr2m May 11, 2021 18:38
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘πŸΌ

@gr2m gr2m merged commit 43223a2 into main May 11, 2021
@gr2m gr2m deleted the add-jsconfig-json-to-check-js-errors branch May 11, 2021 18:43
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.4.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

πŸ’‘ To add // @ts-check
2 participants