Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v7 #831

Merged
merged 120 commits into from
Mar 21, 2023
Merged

v7 #831

merged 120 commits into from
Mar 21, 2023

Conversation

wa-rren-dev
Copy link
Contributor

@wa-rren-dev wa-rren-dev commented Jul 20, 2022 •
edited by andymantell
Loading

Description

This is a fast-moving and relatively cavalier proposal branch for version 7 of the nhsuk-frontend package. Use at your own risk!

See the branch's changelog for info on what's changing.

Before release

  • Write tests for Tabs
  • Write tests for Character Count
  • Experimental label on the frontend demo

andymantell added 30 commits June 24, 2021 15:19
@andymantell
Initial dump of tabs code from govuk-frontend
269bd19
@andymantell
Initial work getting the govuk-frontend tabs component to compile in …
60da720 
…nhsuk
@andymantell
Add basic tabs demo
7a491fb
@andymantell
Add prettierignore file as prettier conflicts with nhs linting rules
1398782
@andymantell
Finishing up styles for tabs
47ba378
@andymantell
Tweak initialisation of tabs so that it matches other components
ddc1361
@andymantell
Bring in improvements from 111 online - configurable namespace and op…
a4ebd98 
…tional responsiveness
@andymantell
Fix linting issues in tabs JS
72d5869
@andymantell
Fix scss linting errors in tabs component
2ebf53b
@andymantell
Tidy up tabs example
434a6c3
@andymantell
Add tabs readme
dab3a0e
@andymantell
Add backstop reference images for new tabs component
eab93ea
@andymantell
Add headings to tab content
d992615
@andymantell
Allow history to be disabled on tabs component
cbd8373
@andymantell
Rework clickable cards using CSS invisible overlay rather than JS eve…
5f152db 
…nt handler

This avoids problems with using Ctrl-click, middle click, right click
to open new tabs since the link just behaves as it would natively

Fixes #758
Fixes #749
@andymantell
Changelog entry for #762
def3854
@andymantell
Trick IE10 into rendering the invisible clickable area on clickable c…
cdcd345 
…ards
@andymantell
CSS linting fix
c16d0a0
@andymantell
CSS linting fix
b51e75a
@andymantell
Dispatch events when tabs are shown / hidden
1d7de11
@andymantell
Merge branch 'master' into feature/rework-clickable-cards
9cb0904
@andymantell
Switch to CustomEvent
946b884
@andymantell
Merge branch 'master' into feature/rework-clickable-cards
e07ef91
@andymantell
Update changelog - move reworked clickable cards to a breaking change
24c426b
@andymantell
Merge branch 'master' into feature/rework-clickable-cards
72d8e9e
@andymantell
remove stray merge marker
0b52bcd
@andymantell
Merge branch 'master' into feature/tabs
cecb7ba
@andymantell
Merge branch 'master' into feature/rework-clickable-cards
a465242
@andymantell
Initial work porting govuk-frontend character count component
adff462
@andymantell
Fix broken links to govuk packages
c4ea4f7
@andymantell andymantell requested a review from pflynny February 27, 2023 08:21
mcheung-nhs
mcheung-nhs requested changes Mar 6, 2023
View reviewed changes
packages/components/character-count/README.md Outdated Show resolved Hide resolved
app/components/all.njk Show resolved Hide resolved
packages/components/tabs/template.njk Show resolved Hide resolved
docs/contributing/git-style-guide.md Outdated Show resolved Hide resolved
docs/installation/installing-compiled.md Outdated Show resolved Hide resolved
packages/components/button/README.md Outdated Show resolved Hide resolved
packages/components/tables/README.md Outdated Show resolved Hide resolved
packages/components/warning-callout/README.md Outdated Show resolved Hide resolved
@pflynny
Update _breadcrumb.scss
d531022 
Update the number references in the comments and remove unused comments.
andymantell

This comment was marked as resolved.

Sign in to view

@andymantell andymantell marked this pull request as ready for review March 13, 2023 18:32
andymantell
andymantell previously approved these changes Mar 20, 2023
View reviewed changes
@andymantell andymantell dismissed their stale review March 20, 2023 18:52

didn't mean to approve the whole PR, needs to be someone other than me

mcheung-nhs
mcheung-nhs requested changes Mar 21, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@andymantell andymantell merged commit ce6b382 into main Mar 21, 2023
@andymantell andymantell deleted the alpha-v7 branch March 21, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andymantell andymantell andymantell left review comments

@mcheung-nhs mcheung-nhs mcheung-nhs approved these changes

@Fenwick17 Fenwick17 Awaiting requested review from Fenwick17

@pflynny pflynny Awaiting requested review from pflynny

Assignees

@wa-rren-dev wa-rren-dev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wa-rren-dev @kevinkuszyk @chrimesdev @andymantell @mcheung-nhs @pflynny