Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update breadcrumbs style #859

Merged
merged 6 commits into from
Mar 16, 2023
Merged

Update breadcrumbs style #859

merged 6 commits into from
Mar 16, 2023

Conversation

pflynny
Copy link
Contributor

@pflynny pflynny commented Mar 2, 2023

Description

Add the updated breadcrumb that has been beta-tested on the live site; we've seen positive use on the new hub pages, and we're happy to apply it to the remainder of the site.

Some context for the update:

Checklist

Copy link
Contributor

@andymantell andymantell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changelog entry

@andymantell
Copy link
Contributor

andymantell commented Mar 2, 2023

Couple of comments above. Otherwise seems reasonable 👍🏻

@fofr
Copy link
Contributor

fofr commented Mar 6, 2023

To summarise this change, is it:

  • removing the white background from the navigation area
  • removing the word "Back" from back links

?

Update the number references in the comments and remove unused comments.
@pflynny
Copy link
Contributor Author

pflynny commented Mar 6, 2023

@fofr there is a reduction in the space between the breadcrumbs and the title of the page, but alongside what you stated, that is it.

@andymantell
Copy link
Contributor

Approved @pflynny - but there's a merge conflict in the readme now. Sorry, that was me fiddling in the other PR 😬

@pflynny pflynny requested a review from mcheung-nhs March 16, 2023 13:14
@pflynny pflynny merged commit bcd4f86 into alpha-v7 Mar 16, 2023
@pflynny pflynny deleted the new-breadcrumbs branch March 16, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants