Add TcbRawInfoVerifier
#98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
nick-mobilecoin
commented
May 24, 2023
❌ Unreviewed dependencies found
|
nick-mobilecoin
commented
May 24, 2023
nick-mobilecoin
commented
May 24, 2023
nick-mobilecoin
requested review from
eranrund and
cbeck88
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## nick/quote-verifier #98 +/- ##
=======================================================
+ Coverage 97.83% 97.90% +0.07%
=======================================================
Files 7 7
Lines 2028 2101 +73
=======================================================
+ Hits 1984 2057 +73
Misses 44 44
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eranrund
approved these changes
May 24, 2023
Add `TcbRawInfoVerifier` which can be composed with other verifiers to verify the signature and date validity of the `TcbRawInfo`.
Previously an `Error` was used for the `TcbInfoRawVerifier`. This required one to set the error even when the verification succeeded. Now an `Option` is used to more clearly delineate an error vs success.
nick-mobilecoin
force-pushed
the
nick/tcb-signature-verifier
branch
from
99cbbf5 to
93c94dd
Compare
8 tasks
|
@nick-mobilecoin started a stack merge that includes this pull request via Graphite. |
|
@nick-mobilecoin merged this pull request with Graphite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
TcbRawInfoVerifierwhich can be composed with other verifiers toverify the signature and date validity of the
TcbRawInfo.Motivation