Add Quote3Verifier
#97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `Quote3Verifier` which can be used with the verifier composition to verify the signature of a `Quote3`.
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
github-actions
bot
added
size/L
nick-mobilecoin
commented
May 24, 2023
❌ Unreviewed dependencies found
|
nick-mobilecoin
commented
May 24, 2023
nick-mobilecoin
requested review from
eranrund and
cbeck88
and removed request for
a team
8 tasks
Codecov Report
@@ Coverage Diff @@
## main #97 +/- ##
==========================================
- Coverage 97.84% 97.83% -0.02%
==========================================
Files 6 7 +1
Lines 1948 2028 +80
==========================================
+ Hits 1906 1984 +78
- Misses 42 44 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Merged
eranrund
approved these changes
May 24, 2023
The comment for modifying the quote in order to cause a signature verification failure has been updated to better explain why the modified byte was chosen.
|
@nick-mobilecoin started a stack merge that includes this pull request via Graphite. |
|
@nick-mobilecoin merged this pull request with Graphite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Quote3Verifierwhich can be used with the verifier composition toverify the signature of a
Quote3.Motivation