Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolset update: VS 2022 17.9 Preview 2, Clang 17 #4259

Merged
merged 23 commits into from
Dec 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
8eec5c0
Update GitHub Actions.
StephanTLavavej Dec 12, 2023
1474612
Update Node.js.
StephanTLavavej Dec 12, 2023
e3ecc30
Use PowerShell 7.4.0.
StephanTLavavej Dec 12, 2023
ec86096
Python 3.12.1.
StephanTLavavej Dec 12, 2023
56285c2
New pool.
StephanTLavavej Dec 12, 2023
88a4c95
VS 2022 17.9 Preview 2.
StephanTLavavej Dec 12, 2023
69fb030
Remove EDG _MSVC_INTERNAL_TESTING workaround in VSO_0000000_type_traits.
StephanTLavavej Dec 13, 2023
d4b5ea7
MSVC changes expected in 17.9 Preview 3 will actually ship in 17.10 P…
StephanTLavavej Dec 13, 2023
51953b3
Remove workaround for VSO-1888462 "Bogus constexpr error C2131 'failu…
StephanTLavavej Dec 13, 2023
8125a57
Remove workarounds for VSO-1899423 "C1XX mishandles C++17 deferred te…
StephanTLavavej Dec 13, 2023
84e6302
Handle `/Zc:noexceptTypes-` after workaround removal.
StephanTLavavej Dec 13, 2023
57edd59
Remove workaround for VSO-1849463 "EDG silently rejects source_locati…
StephanTLavavej Dec 13, 2023
12f702d
[ASAN] Remove workarounds for DevCom-10439535 "import std; with addre…
StephanTLavavej Dec 13, 2023
4f61b92
Test mdspan via modules after the fix for DevCom-10359857 "[C++][Modu…
StephanTLavavej Dec 13, 2023
86bfbeb
Require Clang 17.
StephanTLavavej Dec 13, 2023
2737212
Clang 17 supports `__builtin_FUNCSIG`.
StephanTLavavej Dec 13, 2023
bb1fdf3
Update clang-format 17 defaults.
StephanTLavavej Dec 13, 2023
7733c42
clang-format, no manual changes.
StephanTLavavej Dec 13, 2023
77d10ac
Manually unwrap a line in mdspan. This is "sticky".
StephanTLavavej Dec 13, 2023
257aac1
Add empty comments to improve `IS_MEOW && noexcept(EXPR)`.
StephanTLavavej Dec 13, 2023
30f210b
Remove empty comments with literally no effect.
StephanTLavavej Dec 13, 2023
bf01fc6
Remove clang-format suppressions with literally no effect.
StephanTLavavej Dec 13, 2023
a5bfdb0
Remove or shrink clang-format suppressions, with only minimal, desira…
StephanTLavavej Dec 13, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions .clang-format
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Copyright (c) Microsoft Corporation.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

# https://releases.llvm.org/16.0.0/tools/clang/docs/ClangFormatStyleOptions.html
# https://releases.llvm.org/17.0.1/tools/clang/docs/ClangFormatStyleOptions.html

---
# Language: Cpp
Expand Down Expand Up @@ -38,6 +38,11 @@ AlignConsecutiveAssignments: Consecutive
# AlignCompound: false
# PadOperators: false
AlignConsecutiveMacros: Consecutive
# AlignConsecutiveShortCaseStatements:
# Enabled: false
# AcrossEmptyLines: false
# AcrossComments: false
# AlignCaseColons: false
# AlignEscapedNewlines: Right
AlignEscapedNewlines: Left
# AlignOperands: Align
Expand Down Expand Up @@ -176,6 +181,7 @@ InsertNewlineAtEOF: true
# JavaScriptQuotes: Leave
# JavaScriptWrapImports: true
# KeepEmptyLinesAtTheStartOfBlocks: true
# KeepEmptyLinesAtEOF: false
# LambdaBodyIndentation: Signature
# LineEnding: DeriveLF
LineEnding: CRLF
Expand Down Expand Up @@ -209,6 +215,7 @@ PointerAlignment: Left
# ReferenceAlignment: Pointer
# ReflowComments: true
# RemoveBracesLLVM: false
# RemoveParentheses: Leave
# RemoveSemicolon: false
RemoveSemicolon: true
# RequiresClausePosition: OwnLine
Expand All @@ -228,6 +235,7 @@ SpaceAfterCStyleCast: true
# SpaceBeforeCpp11BracedList: false
# SpaceBeforeCtorInitializerColon: true
# SpaceBeforeInheritanceColon: true
# SpaceBeforeJsonColon: false
# SpaceBeforeParens: ControlStatements
# SpaceBeforeParensOptions:
# AfterControlStatements: true
Expand All @@ -245,16 +253,18 @@ SpaceBeforeParensOptions:
# SpaceBeforeRangeBasedForLoopColon: true
# SpaceBeforeSquareBrackets: false
# SpaceInEmptyBlock: false
# SpaceInEmptyParentheses: false
# SpacesBeforeTrailingComments: 1
# SpacesInAngles: Never
# SpacesInConditionalStatement: false
# SpacesInContainerLiterals: true
# SpacesInCStyleCastParentheses: false
# SpacesInLineCommentPrefix:
# Minimum: 1
# Maximum: -1
# SpacesInParentheses: false
# SpacesInParens: Never
# SpacesInParensOptions:
# InCStyleCasts: false
# InConditionalStatements: false
# InEmptyParentheses: false
# Other: false
# SpacesInSquareBrackets: false
# Standard: Latest
# StatementAttributeLikeMacros:
Expand All @@ -277,6 +287,7 @@ StatementMacros:
- _END_EXTERN_C_UNLESS_PURE
# TabWidth: 8
# UseTab: Never
# VerilogBreakBetweenInstancePorts: true
# WhitespaceSensitiveMacros:
# - BOOST_PP_STRINGIZE
# - CF_SWIFT_NAME
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/move-ready-for-review-prs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Move To Initial Review
uses: actions/github-script@v6
uses: actions/github-script@v7
with:
script: |
// Find "Code Reviews" project manually by name matching
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/move-work-in-progress-prs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Move To Work In Progress
uses: actions/github-script@v6
uses: actions/github-script@v7
with:
script: |
// Find "Code Reviews" project manually by name matching
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/update-status-chart.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout gh-pages
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
ref: gh-pages
- name: Setup Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ">=20.4.0"
node-version: ">=21.4.0"
- name: Install Packages
run: |
npm ci
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ Just try to follow these rules, so we can spend more time fixing bugs and implem

# How To Build With The Visual Studio IDE

1. Install Visual Studio 2022 17.9 Preview 1 or later.
1. Install Visual Studio 2022 17.9 Preview 2 or later.
* Select "Windows 11 SDK (10.0.22000.0)" in the VS Installer.
* We recommend selecting "C++ CMake tools for Windows" in the VS Installer.
This will ensure that you're using supported versions of CMake and Ninja.
Expand All @@ -156,7 +156,7 @@ Just try to follow these rules, so we can spend more time fixing bugs and implem

# How To Build With A Native Tools Command Prompt

1. Install Visual Studio 2022 17.9 Preview 1 or later.
1. Install Visual Studio 2022 17.9 Preview 2 or later.
* Select "Windows 11 SDK (10.0.22000.0)" in the VS Installer.
* We recommend selecting "C++ CMake tools for Windows" in the VS Installer.
This will ensure that you're using supported versions of CMake and Ninja.
Expand Down
2 changes: 1 addition & 1 deletion azure-devops/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

variables:
- name: poolName
value: 'StlBuild-2023-11-15T0519-Pool'
value: 'StlBuild-2023-12-12T1453-Pool'
readonly: true
- name: poolDemands
value: 'EnableSpotVM -equals true'
Expand Down
4 changes: 2 additions & 2 deletions azure-devops/provision-image.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ if ([string]::IsNullOrEmpty($AdminUserPassword)) {
$PsExecPath = Join-Path $ExtractedPsToolsPath 'PsExec64.exe'

# https://github.com/PowerShell/PowerShell/releases/latest
$PowerShellZipUrl = 'https://github.com/PowerShell/PowerShell/releases/download/v7.3.9/PowerShell-7.3.9-win-x64.zip'
$PowerShellZipUrl = 'https://github.com/PowerShell/PowerShell/releases/download/v7.4.0/PowerShell-7.4.0-win-x64.zip'
Write-Host "Downloading: $PowerShellZipUrl"
$ExtractedPowerShellPath = DownloadAndExtractZip -Url $PowerShellZipUrl
$PwshPath = Join-Path $ExtractedPowerShellPath 'pwsh.exe'
Expand Down Expand Up @@ -136,7 +136,7 @@ $Workloads = @(
)

$VisualStudioBootstrapperUrl = 'https://aka.ms/vs/17/pre/vs_enterprise.exe'
$PythonUrl = 'https://www.python.org/ftp/python/3.12.0/python-3.12.0-amd64.exe'
$PythonUrl = 'https://www.python.org/ftp/python/3.12.1/python-3.12.1-amd64.exe'

$CudaUrl = 'https://developer.download.nvidia.com/compute/cuda/11.6.0/local_installers/cuda_11.6.0_511.23_windows.exe'

Expand Down
Loading