Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolset update: VS 2022 17.9 Preview 2, Clang 17 #4259

Merged
merged 23 commits into from
Dec 14, 2023

Conversation

StephanTLavavej
Copy link
Member

  • Code cleanups:
    • Removed compiler bug workarounds.
  • Infrastructure improvements:
    • Updated dependencies.
      • Updated build compiler to VS 2022 17.9 Preview 2.
      • Updated Clang to 17.0.3 (now required).
      • Updated Python to 3.12.1.

Commits:

  • Update GitHub Actions.
  • Update Node.js.
  • Use PowerShell 7.4.0.
  • Python 3.12.1.
  • New pool.
  • VS 2022 17.9 Preview 2.
  • Remove EDG _MSVC_INTERNAL_TESTING workaround in VSO_0000000_type_traits.
    • EDG has been updated internally.
  • MSVC changes expected in 17.9 Preview 3 will actually ship in 17.10 Preview 1.
  • Remove workaround for VSO-1888462 "Bogus constexpr error C2131 'failure was caused by allocated storage not being deallocated'".
  • Remove workarounds for VSO-1899423 "C1XX mishandles C++17 deferred temporary materialization in is_invocable_r_v and is_nothrow_invocable_r_v".
  • Handle /Zc:noexceptTypes- after workaround removal.
  • Remove workaround for VSO-1849463 "EDG silently rejects source_location::current() as a default argument".
  • Remove workarounds for DevCom-10439535 "import std; with address sanitizer option does not compile(C1358)".
  • Test mdspan via modules after the fix for DevCom-10359857 "[C++][Modules] std::mdspan is unusable with C++20 modules".
  • Require Clang 17.
  • Clang 17 supports __builtin_FUNCSIG.
  • Update clang-format 17 defaults.
  • clang-format, no manual changes.
    • Almost all changes are neutral or desirable.
    • In <ranges>, spaces are being lost in _Zip_iterator_sentinel_equal()'s _Evaluate_equality_closure which is annoying but tolerable.
    • In a few files (<ranges>, <xutility>, P0898R3_concepts/test.cpp, P1645R1_constexpr_numeric/test.cpp, P2387R3_pipe_support_for_user_defined_range_adaptors/test.cpp), spaces are appearing in parameters like _Ty &&. This is also annoying but tolerable.
  • Manually unwrap a line in <mdspan>. This is "sticky".
  • Add empty comments to improve IS_MEOW && noexcept(EXPR).
  • Remove empty comments with literally no effect.
  • Remove clang-format suppressions with literally no effect.
  • Remove or shrink clang-format suppressions, with only minimal, desirable reflow.

StephanTLavavej and others added 23 commits December 11, 2023 21:07
…re was caused by allocated storage not being deallocated'".
…mporary materialization in is_invocable_r_v and is_nothrow_invocable_r_v".
…ss sanitizer option does not compile(C1358)".
…les] std::mdspan is unusable with C++20 modules".
Almost all changes are neutral or desirable.

In `<ranges>`, spaces are being lost in `_Zip_iterator_sentinel_equal()`'s `_Evaluate_equality_closure` which is annoying but tolerable.

In a few files (`<ranges>`, `<xutility>`, `P0898R3_concepts/test.cpp`, `P1645R1_constexpr_numeric/test.cpp`, `P2387R3_pipe_support_for_user_defined_range_adaptors/test.cpp`), spaces are appearing in parameters like `_Ty &&`. This is also annoying but tolerable.
@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Dec 13, 2023
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner December 13, 2023 20:13
@StephanTLavavej StephanTLavavej self-assigned this Dec 14, 2023
@StephanTLavavej
Copy link
Member Author

I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 245e703 into microsoft:main Dec 14, 2023
37 checks passed
@StephanTLavavej StephanTLavavej deleted the vs17.9p2 branch December 14, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to repository automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants