-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolset update: VS 2022 17.9 Preview 2, Clang 17 #4259
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EDG has been updated internally.
…re was caused by allocated storage not being deallocated'".
…mporary materialization in is_invocable_r_v and is_nothrow_invocable_r_v".
…on::current() as a default argument".
…ss sanitizer option does not compile(C1358)".
…les] std::mdspan is unusable with C++20 modules".
Almost all changes are neutral or desirable. In `<ranges>`, spaces are being lost in `_Zip_iterator_sentinel_equal()`'s `_Evaluate_equality_closure` which is annoying but tolerable. In a few files (`<ranges>`, `<xutility>`, `P0898R3_concepts/test.cpp`, `P1645R1_constexpr_numeric/test.cpp`, `P2387R3_pipe_support_for_user_defined_range_adaptors/test.cpp`), spaces are appearing in parameters like `_Ty &&`. This is also annoying but tolerable.
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
barcharcraz
approved these changes
Dec 14, 2023
CaseyCarter
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits:
_MSVC_INTERNAL_TESTING
workaround inVSO_0000000_type_traits
.constexpr
error C2131 'failure was caused by allocated storage not being deallocated'".is_invocable_r_v
andis_nothrow_invocable_r_v
"./Zc:noexceptTypes-
after workaround removal.source_location::current()
as a default argument".import std;
with address sanitizer option does not compile(C1358)".mdspan
via modules after the fix for DevCom-10359857 "[C++][Modules]std::mdspan
is unusable with C++20 modules".__builtin_FUNCSIG
.<ranges>
, spaces are being lost in_Zip_iterator_sentinel_equal()
's_Evaluate_equality_closure
which is annoying but tolerable.<ranges>
,<xutility>
,P0898R3_concepts/test.cpp
,P1645R1_constexpr_numeric/test.cpp
,P2387R3_pipe_support_for_user_defined_range_adaptors/test.cpp
), spaces are appearing in parameters like_Ty &&
. This is also annoying but tolerable.<mdspan>
. This is "sticky".IS_MEOW && noexcept(EXPR)
.