Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winapinls.cpp: static_assert is_sorted() for the lookup tables #224

Closed
StephanTLavavej opened this issue Oct 27, 2019 · 2 comments · Fixed by #451
Closed

winapinls.cpp: static_assert is_sorted() for the lookup tables #224

StephanTLavavej opened this issue Oct 27, 2019 · 2 comments · Fixed by #451
Labels
enhancement Something can be improved fixed Something works now, yay!

Comments

@StephanTLavavej
Copy link
Member

After #6 is implemented, we should use constexpr is_sorted() in winapinls.cpp.

@StephanTLavavej StephanTLavavej added enhancement Something can be improved blocked Something is preventing work on this labels Oct 27, 2019
@BillyONeal
Copy link
Member

Note that we compile that thing with MSVC, so even though we can implement #6 now because Clang has support for is_constant_evaluated, we need MSVC to support that before attempting to resolve this item.

@StephanTLavavej
Copy link
Member Author

Also applies to the validate.cpp tool:

// TRANSITION, P0202R3, use constexpr is_sorted()
assert(is_sorted(skipped_directories.begin(), skipped_directories.end()));
assert(is_sorted(skipped_extensions.begin(), skipped_extensions.end()));
assert(is_sorted(tabby_filenames.begin(), tabby_filenames.end()));

@StephanTLavavej StephanTLavavej added work in progress and removed blocked Something is preventing work on this labels Jan 24, 2020
StephanTLavavej added a commit to StephanTLavavej/STL that referenced this issue Jan 24, 2020
StephanTLavavej added a commit to StephanTLavavej/STL that referenced this issue Jan 24, 2020
@StephanTLavavej StephanTLavavej added fixed Something works now, yay! and removed work in progress labels Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved fixed Something works now, yay!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants