-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate.cpp: static_assert is_sorted() for the lookup tables #455
Comments
There's no reason the tools can't use the live STL headers. |
Mixing live headers with installed libs would be doom. Doom! |
I mean, it wouldn't be a supported configuration but the only people it might break would be ourselves |
I'm wary of introducing little bits of weirdness - such things accumulate and make systems difficult to deal with. Waiting is simpler. |
Sure! Wasn't saying "do this thing", was only saying "consider this thing" :) |
@StephanTLavavej - I can work on this issue. Should I assign this to myself? |
Thanks! You can just submit a pull request - we don't usually assign issues to devs outside the vclibs team. A comment is sufficient to indicate to other readers that you're working on an issue. |
Great. Will submit a pull request. |
When VS 2019 16.6 Preview 1 is available, the shipping toolset will support #6
constexpr
is_sorted()
. At that time, this will become a "good first issue"./std:c++latest
. This is accomplished by telling CMake to use C++20 instead of C++17:STL/tools/CMakeLists.txt
Line 7 in a46d897
assert
tostatic_assert
:STL/tools/validate/validate.cpp
Lines 174 to 177 in a46d897
(Related to #224.)
The text was updated successfully, but these errors were encountered: