Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix meeting not updated #466

Merged
merged 10 commits into from
Oct 31, 2024
Merged

fix meeting not updated #466

merged 10 commits into from
Oct 31, 2024

Conversation

sajdakabir
Copy link
Member

@sajdakabir sajdakabir commented Oct 31, 2024

Summary by CodeRabbit

  • New Features

    • Introduced new controllers for fetching Google Calendar meetings and upcoming meetings.
    • Enhanced webhook handling for calendar events with improved validation and error handling.
    • Updated meeting storage to include conference data in the database.
  • Bug Fixes

    • Corrected identifier usage in meeting update and deletion functions to ensure proper database interactions.
  • Chores

    • Improved overall error handling across calendar integration functionalities.

Copy link

coderabbitai bot commented Oct 31, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request enhance the Google Calendar integration within the application. New controllers for fetching meetings and upcoming meetings have been added, along with improved token management. The webhook handling function has been updated for better validation and error handling. Additionally, the service layer has been modified to ensure that the conferenceData field is consistently saved with meeting details. Changes in the meeting service involve updating the identifier used for locating meetings from uuid to _id, aligning with MongoDB practices.

Changes

File Path Change Summary
apps/backend/src/controllers/integration/calendar.controller.js - Added getGoogleCalendarMeetingsController and getGoogleCalendarupComingMeetingsController.
- Updated handleCalendarWebhook for token validation and resource state checks.
apps/backend/src/services/integration/calendar.service.js - Updated saveUpcomingMeetingsToDatabase to include conferenceData in the metadata.
- Modified handleCalendarWebhookService to ensure conferenceData is saved during event processing.
apps/backend/src/services/page/meeting.service.js - Changed meeting identifier from uuid to _id in updateMeeting and deleteMeeting functions.

Possibly related PRs

  • Meeting order #380: This PR modifies the calendar.service.js file, which is also altered in the main PR, specifically focusing on the handling of Google Calendar events and the integration with the database for meetings.
  • feat: check cal connection before api call #399: This PR introduces a check for the Google Calendar integration status before making API calls, which relates to the main PR's enhancements in handling Google Calendar meetings and ensuring valid access tokens.

Suggested reviewers

  • joaorceschini
  • oliursahin

Poem

In the garden where meetings bloom,
Google Calendar dispels the gloom.
With tokens refreshed and data in hand,
We sync our events, oh so grand!
Errors handled with care and grace,
In this digital world, we find our place. 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sajdakabir sajdakabir merged commit 3e3c315 into preview Oct 31, 2024
4 of 5 checks passed
@sajdakabir sajdakabir deleted the dev branch October 31, 2024 05:36
@coderabbitai coderabbitai bot mentioned this pull request Nov 27, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant