Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix torch nightly tests: Temporarily add torchdata as a dependency for nightly installation #3808

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Fix torch nightly tests: Temporarily add torchdata as a dependency for nightly installation #3808

merged 1 commit into from
Dec 6, 2023

Conversation

arnavgarg1
Copy link
Contributor

See #3807

@arnavgarg1 arnavgarg1 changed the title Add torchdata as a dependency for nightly installation Fix torch nightly tests: Add torchdata as a dependency for nightly installation Dec 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Unit Test Results

  6 files  +  2    6 suites  +2   14m 26s ⏱️ + 4m 41s
12 tests ±  0    9 ✔️ ±  0    3 💤 ±0  0 ❌ ±0 
60 runs  +20  42 ✔️ +14  18 💤 +6  0 ❌ ±0 

Results for commit 1651fb5. ± Comparison against base commit 0e01674.

@arnavgarg1 arnavgarg1 changed the title Fix torch nightly tests: Add torchdata as a dependency for nightly installation Fix torch nightly tests: Temporarily add torchdata as a dependency for nightly installation Dec 6, 2023
alexsherstinsky
alexsherstinsky approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@alexsherstinsky alexsherstinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arnavgarg1 arnavgarg1 merged commit 21d3ab2 into master Dec 6, 2023
18 checks passed
@arnavgarg1 arnavgarg1 deleted the fix_py310 branch December 6, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsherstinsky alexsherstinsky alexsherstinsky approved these changes

@justinxzhao justinxzhao Awaiting requested review from justinxzhao justinxzhao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnavgarg1 @alexsherstinsky