Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on torchdata for torch nightly installation #3807

Closed
arnavgarg1 opened this issue Dec 6, 2023 · 0 comments · Fixed by #3855
Closed

Remove dependency on torchdata for torch nightly installation #3807

arnavgarg1 opened this issue Dec 6, 2023 · 0 comments · Fixed by #3855

Comments

@arnavgarg1
Copy link
Contributor

Our CI is currently failing with torch nightly: https://github.com/ludwig-ai/ludwig/actions/runs/7098011269/job/19319143677

Based on a discussion with the Torch team, this is related to failed builds over the last two days (https://hud.pytorch.org/hud/pytorch/data/nightly/1?per_page=50), 12-04-2023 and 12-05-2023.

The issue stems from a dependency mismatch between torchtext and torchdata.

The torch team has a PR in the pipeline to resolve this issue: pytorch/text#2218. However, it looks like it's currently failing so we will have to wait for this to land.

In the interim, I've added a temporary workaround that installs the latest stable version of torchdata first and then installs torchtext nightly. This seems to work just fine. In the future, once pytorch/text#2218 lands, we will want to remove our explicit install of torchdata for torchnightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant