Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ProcessRunner code leaving Nox to run Procfiles #720

Merged
merged 2 commits into from
Jan 3, 2022
Merged

Remove ProcessRunner code leaving Nox to run Procfiles #720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c325763
Remove ProcessRunner code, using only Nox
matthewmcgarvey Jan 1, 2022
3d188c6
Remove missed usages of deleted code
matthewmcgarvey Jan 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions spec/lucky_cli/dev_spec.cr
View file
Open in desktop

This file was deleted.

57 changes: 0 additions & 57 deletions spec/lucky_cli/process_runner_spec.cr
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions src/dev.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
class LuckyCli::Dev < LuckyTask::Task
summary "Start your app with a process runner and Procfile.dev"
summary "Starts your app by running the processes found in Procfile.dev"

def call(process_runner = LuckyCli::ProcessRunner)
process_runner.start
def call
::Nox.run("Procfile.dev")
end
end
21 changes: 0 additions & 21 deletions src/ensure_process_runner_installed.cr
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions src/lucky.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ require "./lucky_cli"
require "./generators/*"
require "./dev"
require "./build_and_run_task"
require "./ensure_process_runner_installed"

include LuckyTask::TextHelpers

Expand All @@ -28,8 +27,6 @@ end

if task_name == "dev"
LuckyCli::Dev.new.call
elsif task_name == "ensure_process_runner_installed"
LuckyCli::EnsureProcessRunnerInstalled.new.call
elsif task_name == "gen.tasks_file"
LuckyCli::Generators::TasksFile.run
elsif task_name == "init"
Expand Down
102 changes: 0 additions & 102 deletions src/lucky_cli/process_runner.cr
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions src/web_app_skeleton/script/system_check.ecr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@ if command_not_found "yarn"; then
fi
<%- end -%>

# Only if this isn't CI
if [ -z "$CI" ]; then
lucky ensure_process_runner_installed
fi

if command_not_found "createdb"; then
MSG="Please install the postgres CLI tools, then try again."
if is_mac; then
Expand Down