Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ProcessRunner code leaving Nox to run Procfiles #720

Merged
merged 2 commits into from
Jan 3, 2022

Conversation

matthewmcgarvey
Copy link
Member

@matthewmcgarvey matthewmcgarvey commented Jan 1, 2022

Closes #714
Closes #688

The previous PR added Nox as a process runner. Since it's a shard instead of a process installed on users' machines, it's guaranteed to be present so we don't need the ProcessRunner code anymore. Consequently also removed the use of the ensure_process_runner_installed task which I never even knew existed.

This is a breaking change. Projects will need to update script/system_check and delete these lines

# Only if this isn't CI
if [ -z "$CI" ]; then
  lucky ensure_process_runner_installed
fi

@jwoertink jwoertink added the BREAKING CHANGE This will cause a breaking change label Jan 3, 2022
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@matthewmcgarvey matthewmcgarvey merged commit b215ac3 into master Jan 3, 2022
@matthewmcgarvey matthewmcgarvey deleted the remove-process-runners branch January 3, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This will cause a breaking change
Projects
None yet
2 participants