docs: remove references to dead metric tcp_connection_duration_ms
#1905
Conversation
This metric was dropped in linkerd/linkerd2-proxy#930 Signed-off-by: Nicklas Møller <[email protected]>
nicklasmoeller
force-pushed
the
nicklasmoeller/push-nktxwyqkrmrv
branch
from
20529b0 to
7c890f1
Compare
|
The content here looks great, but it looks to me like the metric was in fact removed in stable-2.10.0 – @alpeb, can you doublecheck? |
|
Happy to change things around - I'm basing the version on the upgrade guide mentioning that it's dropped in 2.11 (under other changes, second bullet): https://github.com/linkerd/website/blob/24b6dba0bd8c1698578df28766858b2a3f789cd3/linkerd.io/content/2.15/tasks/upgrade.md#upgrade-notice-stable-2110 |
|
It was removed in linkerd/linkerd2-proxy#930, which was included in the proxy v2.135.0, which was indeed picked in stable-2.10.0 as per linkerd/linkerd2@190f2b1 |
|
Alright - I'll drop it from 2.10 docs as well, and keep the upgrade notes across all versions unchanged, even though the version attribution there is incorrect - or do you prefer that we get that changed as well? |
|
I'd vote to change it in the upgrade notes as well, if that's easy? |
Signed-off-by: Nicklas Møller <[email protected]>
This metrics was removed in 2.10, but was incorrectly attributed to 2.11 in the upgrade docs, as of linkerd@e9ae777#diff-f4328e2dffc88e1711b12c9719e0f948d4bdd73be957179eeb3ceacc8391fe29 It was never incorporated into the original 2.10 docs: https://github.com/linkerd/website/blob/e9ae7770ea685336aa9b2aa0b9f802b028f9aa76/linkerd.io/content/2.10/tasks/upgrade.md Opting to just leave it out - it's been years on end, and the metric itself was taken out due to a memory leak: it's not super likely that someone will come around in the future, missing the metric, after potentially upgrading from 2.10. Signed-off-by: Nicklas Møller <[email protected]>
|
I've removed all references now - hope you're OK with that. Moving the note around doesn't really make a lot of sense, without altering the content, and making space for it in another paragraph. Also, it just seems to incorrectly have sneaked into 2.11 notes instead of 2.10 - more reasoning in the commit message. |
This metric was dropped in linkerd/linkerd2-proxy#930
It's still kept around in the 2.10 docs, since it was only removed from 2.11