fix(frontend): Display loop UI for pipelines page #489
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fenglixa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| if ( | ||
| pipeline['metadata'] && | ||
| pipeline['metadata']['annotations'] && | ||
| pipeline['metadata']['annotations']['tekton.dev/' + loopPipelineName] |
There was a problem hiding this comment.
Do we have any sample pipelines using this annotation?
There was a problem hiding this comment.
Thanks @drewbutlerbb4 , yes, I will modify sdk part test examples for it, but seems I have to suspend this PR due to this logic should be removed after custom task could be defined as taskSpec
| @@ -97,7 +103,8 @@ function buildTektonDag(graph: dagre.graphlib.Graph, template: any): void { | |||
| (pipeline['spec']['pipelineSpec']['finally'] || []).map((element: any) => { | |||
| return element['name']; | |||
| }) || []; | |||
| // Collect the anyConditions from 'metadata.annotations.anyConditions' | |||
| let loopNumber = 1; | |||
There was a problem hiding this comment.
loopNumber is always 1. It should be incremented somewhere
|
/hold Since the code need to be modified after tektoncd/pipeline#3682 addressed |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it. |
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Address the loops UI dispaly in static pipelines page.
Run page was blocked by issue #488 now.
Environment tested:
python --version):tkn version):kubectl version):/etc/os-release):Checklist:
Do you want this pull request (PR) cherry-picked into the current release branch?
Learn more about cherry-picking updates into the release branch.