-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Get apis/v1beta1/runs/${run-id} didn't get the full status, if custom task was defined in the pipeline #488
Comments
@Tomcli , do you know who is familar with this issue? |
Right now, the Get apis/v1beta1/runs/${run-id} only returns the pipelinerun spec which doesn't include the pipeline loop spec due to tektoncd/pipeline#3682 |
Although we can make the api to do some extra api calls for getting the custom task crd, but it will need to alter the api spec and it could add some extra workloads to the etcd and loop controller. Maybe I can make it as an experimental feature for now so people can opt-out if they don't want to decrease performance. |
Oh i think this also requires to alter the database schema since we need a place to store the custom task crd... |
Thanks @Tomcli, this issue is not related to TaskSpec defination for custom task. |
@fenglixa sorry i couldn't reproduce this issue. I believe you also use kfp-tekton 0.7? In kfp-tekton 0.7 with custom task, this is what i get from the runs api. It returns the PipelineRun CR result. The runs status is under status.run. and regular task status is under status.taskruns.
|
@Udiknedormin @fenglixa for getting all the information in one pipelinerun yaml, I have a PR over here #512 (need to fix some tests) @fenglixa do you have an example that can reproduce this issue? Do you see it when the pipeline is running or completed? |
Based on comments from Tomcli, I am worried the api-server is an old one in my cluster caused this issue. |
/kind bug
What steps did you take and what happened:
[A clear and concise description of what the bug is.]
What did you expect to happen:
Call GET apis/v1beta1/runs/${run-id} should get the complete result of this run
Additional information:
[Miscellaneous information that will assist in solving the issue.]
Environment:
python --version
):tkn version
):kubectl version
):/etc/os-release
):The text was updated successfully, but these errors were encountered: