Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting unused fields in ExtendedEmailPublisherDescriptor #517

Merged
merged 2 commits into from
May 13, 2024
Merged

Deleting unused fields in ExtendedEmailPublisherDescriptor #517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ba449b
Deleting unused fields in `ExtendedEmailPublisherDescriptor`
jglick May 10, 2024
2b18a5c
Fixing `JellyScriptContentTest` https://github.com/jenkinsci/email-ex…
jglick May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions src/main/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,21 +65,10 @@ public final class ExtendedEmailPublisherDescriptor extends BuildStepDescriptor<
*/
private String defaultSuffix;

/**
* Jenkins's own URL, to put into the e-mail.
*/
private transient String hudsonUrl;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since 87d418d

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly....

testChangeLogDisplayShouldntOnlyRelyOnPortableMethods2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And why was ca20d1a accessing this field via reflection?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 2b18a5c, whatever that was for.


private MailAccount mailAccount = new MailAccount();

private List<MailAccount> addAccounts = new ArrayList<>();

/**
* The e-mail address that Jenkins puts to "From:" field in outgoing
* e-mails. Null if not configured.
*/
private transient String adminAddress;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since 6f5dd8f


private String charset;

/**
Expand Down Expand Up @@ -154,8 +143,6 @@ public final class ExtendedEmailPublisherDescriptor extends BuildStepDescriptor<

private boolean debugMode = false;

private transient boolean enableSecurity = false;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since 675f4c2


/**
* If true, then the 'Email Template Testing' link will only be displayed
* for users with ADMINISTER privileges.
Expand Down
4 changes: 0 additions & 4 deletions src/test/java/hudson/plugins/emailext/plugins/content/JellyScriptContentTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@ public void before() throws Throwable {
f.setAccessible(true);
f.set(publisher.getDescriptor(), "[email protected]");

f = ExtendedEmailPublisherDescriptor.class.getDeclaredField("hudsonUrl");
f.setAccessible(true);
f.set(publisher.getDescriptor(), "http://localhost/");

build = mock(AbstractBuild.class);
AbstractProject<?, ?> project = mock(AbstractProject.class);
DescribableList publishers = mock(DescribableList.class);
Expand Down