Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting unused fields in ExtendedEmailPublisherDescriptor #517

Merged
merged 2 commits into from
May 13, 2024

Conversation

jglick
Copy link
Member

@jglick jglick commented May 10, 2024

My IDE highlighted these as never read nor written.

@jglick jglick requested a review from a team as a code owner May 10, 2024 19:49
/**
* Jenkins's own URL, to put into the e-mail.
*/
private transient String hudsonUrl;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since 87d418d

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And why was ca20d1a accessing this field via reflection?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 2b18a5c, whatever that was for.

* The e-mail address that Jenkins puts to "From:" field in outgoing
* e-mails. Null if not configured.
*/
private transient String adminAddress;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since 6f5dd8f

@@ -154,8 +143,6 @@ public final class ExtendedEmailPublisherDescriptor extends BuildStepDescriptor<

private boolean debugMode = false;

private transient boolean enableSecurity = false;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since 675f4c2

Copy link
Member

@slide slide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@slide slide merged commit 45d1eca into jenkinsci:master May 13, 2024
16 checks passed
@jglick jglick deleted the unused-fields branch May 13, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants