-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deleting unused fields in ExtendedEmailPublisherDescriptor
#517
Conversation
/** | ||
* Jenkins's own URL, to put into the e-mail. | ||
*/ | ||
private transient String hudsonUrl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since 87d418d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And why was ca20d1a accessing this field via reflection?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 2b18a5c, whatever that was for.
* The e-mail address that Jenkins puts to "From:" field in outgoing | ||
* e-mails. Null if not configured. | ||
*/ | ||
private transient String adminAddress; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since 6f5dd8f
@@ -154,8 +143,6 @@ public final class ExtendedEmailPublisherDescriptor extends BuildStepDescriptor< | |||
|
|||
private boolean debugMode = false; | |||
|
|||
private transient boolean enableSecurity = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since 675f4c2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
My IDE highlighted these as never read nor written.