Add aws-java-sdk

[chriskilding]

Add the Jenkins packaged version of aws-java-sdk plugin, since it has opinions about Jackson, and there are quite a few AWS integration plugins that depend on it.

Requires #282 to be merged first.

[chriskilding]

For discussion:

• How far is the plugin BOM's reach meant to extend? Does it potentially cover any plugin used by 2 or more downstream plugins? Or is it intended to be loosely limited to the plugins exposing Jenkins abstractions and APIs (pipeline, workflow, credentials etc), in which case aws-java-sdk is out of scope?
• If we add aws-java-sdk, we would expect to add the other major cloud providers' packaged SDKs too (presuming there are 2 or more downstream plugins using them). Does this alter our thinking?

[oleg-nenashev]

I am fine with adding a generic API plugin like AWS SDK. The main problem with the approach is that it will have no real test coverage without adding plugins depending on it.

How far is the plugin BOM's reach meant to extend?

IMHO we should rather consider creating sub-repositories for technology-specific plugins. E.g. there could be "jenkinsci/aws-plugins-bom" or "jenkinsci/azure-plugins-bom"which would integrate such plugins on the top of the existing BOM set. It would also allow creating dedicated test suites for plugin sets, e.g. powered by LocalStack in the case of AWS

[chriskilding]

Sounds reasonable to have tech stack specific BOMs on top of this BOM, if there are enough downstream plugins within that tech stack to make it worthwhile.

E.g. I could see the value of knowing (through PCT) that all the AWS integration plugins will work together when installed together.

[jglick]

it will have no real test coverage without adding plugins depending on it

You can add something like artifact-manager-s3 but it will not help much: that plugin’s tests require either a live AWS login, or Docker (for testing MinIO compatibility), neither of which would be available in bom CI. artifact-manager-s3’s own Jenkinsfile will run the MinIO tests, and CloudBees maintains private infrastructure to run its AWS tests, but this is all lost in the more limited and generic PCT environment.

sub-repositories for technology-specific plugins

Too complex, 👎.

I do not have a problem with this PR, assuming you can get CI passing, though again it will be of limited value because including it in the BOM is not doing much to catch actual regressions.

[jglick]

Is this still active?

[chriskilding]

I'm going to close it for now, since we can't run tests for the SDK if we were to include it.