Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jackson2-api #282

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Add jackson2-api #282

merged 2 commits into from
Jul 31, 2020

Conversation

chriskilding
Copy link
Contributor

No description provided.

@chriskilding
Copy link
Contributor Author

chriskilding commented Jul 21, 2020 •
edited
Loading

Using 2.11.0 for now, because io.jenkins.configuration-as-code:test-harness:1.41 bundles Jackson 2.11.0.

If we wanted to merge this with 2.11.1, Dependabot has made a start at updating the test-harness in jenkinsci/configuration-as-code-plugin#1430.

@chriskilding chriskilding mentioned this pull request Jul 21, 2020
Merged
@chriskilding
Copy link
Contributor Author

chriskilding commented Jul 21, 2020 •
edited
Loading

We are caught in a bind...

Past BOMs up to 2.204 include CasC test harness 1.36, which needs Jackson 2.10.2.

Later BOMs include CasC test harness 1.41, which needs Jackson 2.11.0.

We have to satisfy both of them to make the build pass.

We might have to sit on this until support for Jenkins 2.204 ends, and then use 2.11.0.

@jetersen
Copy link
Member

Simply do the same thing we do for JCasC 😅

@jetersen
Copy link
Member

jetersen commented Jul 21, 2020 •
edited
Loading

Oh it's just the sample plugin, I would simply exclude the jackson databinding from the jcasc test-harness.

@jglick jglick added the enhancement New feature or request label Jul 21, 2020
@chriskilding chriskilding mentioned this pull request Jul 27, 2020
Merged
4 tasks
@jetersen
Copy link
Member

The JCasC test harness can definitely use the BOM and same jackson version to avoid conflicts 👍

I think this is ready for merge?

@timja
Copy link
Member

timja commented Jul 27, 2020

Need to resolve #277 first AFAIK

@jetersen
Copy link
Member

The test passed though @timja ? 😕

@chriskilding chriskilding mentioned this pull request Jul 30, 2020
Closed
@timja timja merged commit cf74d22 into jenkinsci:master Jul 31, 2020
@chriskilding chriskilding deleted the add-jackson2-api branch July 31, 2020 09:32
@jglick jglick mentioned this pull request Oct 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jetersen jetersen jetersen approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chriskilding @jetersen @timja @jglick