Adding a trait to allow disabling build notifications. #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since notifications is core to this plugin one could argue this trait should stay in this plugin. cc @stephenc 😅 |
|
I think this should belong in an extension plugin. I believe that people should be able to disable (which is why it is exposed at the API level) but that the majority of users should not be exposed to the option until they need it... hence extension plugin Closing because we will not merge this change in core. The code itself is good and looks correct, but belongs in an extension plugin. @Casz might help show you examples of how to do that |
|
@alex-dubrouski see #127 (comment) for reference 😅 |
|
Thanks anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rely heavily on BitBucket Branch Source plugin, but for couple of root builds we need to disable notifications. These builds are verifying custom scenarios and failure of a build is not an unexpected scenario, though it results in multiple build statuses being posted back to repository which is confusing and annoying. I noticed that there is already parameter which disables build notifications and decided to add a trait to expose it.