Adding Bitbucket repository information to request to allow traits to filter by project

[michelzanini]

Hi,

I have written a trait to filter Bitbucket cloud projects as originally tried on PR #16.

However, it was suggested that such traits could be an extension plugin. I will implement such plugin but I need more information to be available so a trait can filter a project without doing any more additional API calls.

This changes here are adding the BitbucketRepository object to a request, that can later be filtered by a trait. I also included additional JSON fields to parse the project.

I have tested this with both Bitbucket server and cloud.
I have not added or changed any test cases as I do not see any tests testing the parts I have changed, please advise, if necessary I can add them.

Thanks.

[jetersen]

Please add newline at the end of file to files that is missing it.
Please provide a unit test to the new trait filters

[stephenc]

@Casz can you provide assistance on how @michelzanini can move this code into an extension plugin. I’m currently tied up on other stuff and I don’t want them getting disillusioned and abandoning their efforts.

@michelzanini This looks good, but the policy I have been following is to encourage people to put these kind of traits in an extension plugin. It shouldn’t be too hard to do, mostly just create a github repo, steal a pom.xml file (and make minor edits) and get yourself as a plugin maintainer.

[jetersen]

@stephenc gotcha 😅

@michelzanini take a look the one of the following trait plugins to create an extension plugin:
https://github.com/jenkinsci/scm-trait-commit-skip-plugin
https://github.com/jenkinsci/scm-filter-aged-refs-plugin
https://github.com/jenkinsci/scm-filter-jira-validator-plugin

if you need any questions answered, please, ask away 👍

[michelzanini]

Hi @stephenc ,

The problem of doing it as an extension plugins is that I won't be able to pass down the project key / name from the first request that is done to Bitbucket.
I would probably need to make yet another request to Bitbucket, and that could be a blocker for me. I am actually doing this PR because my organisation has 1200+ projects, some of them with hundreds of branches. This PR would help me scan only one project and decrease that time.
Via extension plugin, if I make two requests, it could still be slow :(

[jetersen]

The edit to the JSON @michelzanini would properly be allowed in this plugin, but the filtering will have to be in the extension plugin so should be all good 👍

[michelzanini]

Ok @Casz so I will move the traits out of here to an extension plugin and keep the JSON and BitbucketSCMNavigator / BitbucketSCMNavigatorRequest changes in this PR.

[jetersen]

Sounds like a plan 👍

[jetersen]

@michelzanini you can deploy a snapshot if use mvn deploy though it requires that you signup here: https://accounts.jenkins.io/signup and once signed up you can login here: https://repo.jenkins-ci.org/webapp/#/home and then you are allowed to mvn deploy 👍
You need to setup a settings.xml for maven, that you will most likely need for hosting the extension plugin anyway 😅 https://wiki.jenkins.io/display/JENKINS/Hosting+Plugins#HostingPlugins-Releasingtojenkins-ci.org

[jetersen]

Looks awesome 👍

[michelzanini]

I have changed the PR description to match the code and updated it so I can implement the extension plugin on top of this.

[stephenc]

@rsandell can you review if you get a chance?

[coltrey]

@michelzanini Let me know if you'd like additional testing - I'm looking forward to this feature being available.

[michelzanini]

Thanks @coltrey ,
I have the extension plugin to filter projects working locally already, but until I don't get this PR merged I can't publish it...
I believe I also will need #128 to make a temporary build available to my plugin, to be able to continue... waiting on this to be merged.

[stephenc]

@amuniz can you cut a release?

[michelzanini]

@stephenc there is a good amount of PRs that will be good to merge in this repository:
#131
#130
#128

And some others.
@amuniz , maybe you could include those on a release as well?

Thanks!

[stephenc]

I don’t have time to review much

[cyrus-mc]

With this change merged and a new release of the branch source plugin released I was expecting to find the ability to filter based on projects (for BB Cloud). However I don't see any new capability to filter based on project.

[michelzanini]

@cyrus-mc It will be done on a separated plugin, I am working on it. Should be out in a week or so.

[michelzanini]

@cyrus-mc , @coltrey , this plugin is now released and available here:
https://plugins.jenkins.io/bitbucket-filter-project-trait