Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calls to /apps use etag even though Endpoint does not support it #73

Open
schneems opened this issue Jun 15, 2017 · 1 comment
Open

Calls to /apps use etag even though Endpoint does not support it #73

schneems opened this issue Jun 15, 2017 · 1 comment

Comments

@schneems
Copy link
Contributor

There is an issue in API where the etag for paginated items is not generated. Due to this the same the heroics client will always see a 304 from the /apps endpoint and always return the same list even if things have changed.

Here's an internal ticket about the issue:
https://github.com/heroku/api/issues/7691

This is a blocker to upgrade the Ruby buildpack and Java Buildpack test suites away from v2 of the API.

Wondering if we could add some kind of an option or method invocation to disable etag checking for certain calls, that would work around the issue in the short term.
@schneems
Copy link
Contributor Author

It was suggested in another thread to disable caching as a temporary work around #15 (comment)

schneems added a commit to heroku/hatchet that referenced this issue Jun 16, 2017
@schneems
Update to use V3 of API
329ffb5 
## Platform-api gem

Use the platform-api gem which is a Heroku v3 API gem.

## Heroku 16 Compliant

- Does not support Ruby 1.9.3
- 

## Replace Test Unit with Minitest

This isn't strictly necessary, but the test format of Test Unit became practically unreadable and was hurting my eyes.

## Known Issues

- 304 etag based caching is disabled due to heroku/platform-api#73

- `deployed?` could be improved to check for build success and then that the formations endpoint to ensure that `web` was `up`.
@schneems schneems mentioned this issue Jun 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schneems