Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use V3 of API #35

Merged
merged 6 commits into from
Jun 16, 2017
Merged

Update to use V3 of API #35

merged 6 commits into from
Jun 16, 2017

Conversation

schneems
Copy link
Contributor

@schneems schneems commented Jun 16, 2017

Platform-api gem

Use the platform-api gem which is a Heroku v3 API gem.

Heroku 16 Compliant

  • Does not support Ruby 1.9.3

Replace Test Unit with Minitest

This isn't strictly necessary, but the test format of Test Unit became practically unreadable and was hurting my eyes.

Known Issues

## Platform-api gem

Use the platform-api gem which is a Heroku v3 API gem.

## Heroku 16 Compliant

- Does not support Ruby 1.9.3
- 

## Replace Test Unit with Minitest

This isn't strictly necessary, but the test format of Test Unit became practically unreadable and was hurting my eyes.

## Known Issues

- 304 etag based caching is disabled due to heroku/platform-api#73

- `deployed?` could be improved to check for build success and then that the formations endpoint to ensure that `web` was `up`.
@schneems schneems requested a review from jkutner June 16, 2017 19:05
@jkutner
Copy link
Contributor

jkutner commented Jun 16, 2017

I think we can remove the CLI by replacing the teardown task with something like this:

  task :teardown_travis do
    key_to_delete = `cat ~/.ssh/id_rsa.pub`
    keys_json = `curl -sn https://api.heroku.com/account/keys -H "Accept: application/vnd.heroku+json; version=3"`
    require 'json'
    keys = JSON.parse(keys_json)
    keys.each do |key|
      key_parts = key["public_key"].split(" ")
      if key_parts[1] == key_to_delete.split(" ")[1]
        puts "Deleting #{key_parts[1]}"
        `curl -sn -X DELETE https://api.heroku.com/account/keys/#{key["id"]} -H "Accept: application/vnd.heroku+json; version=3"`
      end
    end
  end

@schneems schneems merged commit 16af66c into master Jun 16, 2017
@edmorley edmorley deleted the schneems/v3-api branch August 27, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants