Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ElastiCache Global Replication Group basic support #17615

Merged
merged 27 commits into from
Feb 19, 2021
Merged

Adds ElastiCache Global Replication Group basic support #17615

merged 27 commits into from
Feb 19, 2021

Conversation

gdavison
Copy link
Contributor

Continues work started in #15885 by @MqllR

Adds basic support for creating a ElastiCache Global Replication Group. Still needs additional support in aws_elasticache_replication_group to support adding secondary replication groups to the aws_elasticache_global_replication_group.

Relates #12708

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSElasticacheGlobalReplicationGroup_'

--- PASS: TestAccAWSElasticacheGlobalReplicationGroup_basic (1460.53s)
--- PASS: TestAccAWSElasticacheGlobalReplicationGroup_disappears (1688.66s)
--- PASS: TestAccAWSElasticacheGlobalReplicationGroup_Description (1750.20s)

MqllR and others added 18 commits October 6, 2020 22:18
@MqllR
feat: implement the elasticache_global_replication_group resource
42388a0
@MqllR
feat: manage the global replication group deletion
45d9c5a
@MqllR
feat: create the base documentation page for elasticache_global_repli…
a2264f0 
…cation_group
@MqllR
feat: add basic acceptance test and initiate doc
5f98c7f
@MqllR
feat: improve doc resource page and fix fmt test
57a8afa
@MqllR
fix misspell words
60850dd
@MqllR
add disappears tests
43280e9
@MqllR
feat: implement the elasticache_global_replication_group resource
02b5f60
@MqllR
feat: manage the global replication group deletion
348260e
@MqllR
feat: create the base documentation page for elasticache_global_repli…
5e266b6 
…cation_group
@MqllR
feat: add basic acceptance test and initiate doc
adc8f6b
@MqllR
feat: improve doc resource page and fix fmt test
e362f58
@MqllR
fix misspell words
19996bd
@MqllR
add disappears tests
6de6f93
@MqllR
Merge branch 'elasticache_global_replication_group' of github.com:Mql…
15ee11e 
…lR/terraform-provider-aws into elasticache_global_replication_group
@gdavison
Merge branch 'main' into elasticache_global_replication_group
8d3e4a9
@gdavison
Fixes acceptance tests and moves waiter functions to service waiter p…
cc7380f 
…ackage
@gdavison
Removes commented code
c86c0cc
@gdavison gdavison requested a review from a team as a code owner February 15, 2021 07:27
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/elasticache Issues and PRs that pertain to the elasticache service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 15, 2021
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Feb 16, 2021
@bflad bflad self-assigned this Feb 18, 2021
@bflad bflad added the new-resource Introduces a new resource. label Feb 18, 2021
bflad
bflad approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks pretty good, just some minor things to consider before merge. 👍

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSElasticacheGlobalReplicationGroup_disappears (1537.14s)
--- PASS: TestAccAWSElasticacheGlobalReplicationGroup_Description (1646.47s)
--- PASS: TestAccAWSElasticacheGlobalReplicationGroup_basic (1853.08s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSElasticacheGlobalReplicationGroup_basic (956.13s)
--- PASS: TestAccAWSElasticacheGlobalReplicationGroup_Description (980.74s)
--- PASS: TestAccAWSElasticacheGlobalReplicationGroup_disappears (1015.49s)

aws/internal/envvar/funcs_test.go Outdated Show resolved Hide resolved
aws/internal/envvar/funcs_test.go Outdated Show resolved Hide resolved
aws/internal/service/elasticache/finder/finder.go Outdated Show resolved Hide resolved
aws/internal/service/elasticache/finder/finder.go Outdated Show resolved Hide resolved
aws/resource_aws_elasticache_global_replication_group.go
conn := meta.(*AWSClient).elasticacheconn

// Only one field can be changed per request
updaters := map[string]elasticacheGlobalReplicationGroupUpdater{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would recommend refactoring this "clever" logic in preference of simpler per attribute checks for consistency with the rest of the provider, especially in the future when attribute change ordering might matter. 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was left over from deferred work to that allows updating other fields on the resource

aws/resource_aws_elasticache_global_replication_group_test.go Outdated Show resolved Hide resolved
aws/resource_aws_elasticache_global_replication_group_test.go Outdated Show resolved Hide resolved
aws/resource_aws_elasticache_global_replication_group_test.go Outdated Show resolved Hide resolved
aws/resource_aws_elasticache_global_replication_group_test.go Outdated Show resolved Hide resolved
aws/resource_aws_elasticache_global_replication_group_test.go Outdated Show resolved Hide resolved
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Feb 18, 2021
@gdavison gdavison merged commit 00649b8 into main Feb 19, 2021
@gdavison gdavison deleted the elasticache_global_replication_group branch February 19, 2021 01:02
@github-actions github-actions bot added this to the v3.29.0 milestone Feb 19, 2021
github-actions bot pushed a commit that referenced this pull request Feb 19, 2021
Update CHANGELOG.md for #17615
962ebd5
@gdavison gdavison mentioned this pull request Feb 19, 2021
Closed
3 tasks
@ghost
Copy link

ghost commented Feb 19, 2021

This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@gdavison gdavison mentioned this pull request Feb 19, 2021
Merged
@ghost
Copy link

ghost commented Mar 21, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/elasticache Issues and PRs that pertain to the elasticache service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.29.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gdavison @bflad @MqllR