Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Update support for ElastiCache Global Replication Group #17696

Closed
3 tasks done
gdavison opened this issue Feb 19, 2021 · 5 comments · Fixed by #27134
Closed
3 tasks done

Extend Update support for ElastiCache Global Replication Group #17696

gdavison opened this issue Feb 19, 2021 · 5 comments · Fixed by #27134
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service.
Milestone

Comments

@gdavison
Copy link
Contributor

gdavison commented Feb 19, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The PRs #15885 and #17615 add basic support for ElastiCache Global Replication Groups. However, only the global_replication_group_description field can be updated. The ElastiCache API allows updating AutomaticFailoverEnabled, CacheNodeType, CacheParameterGroupName, and EngineVersion once a Global Replication Group has been created.

Add the ability to modify these parameters during an Update operation and call the Update operation as part of the Create operation.

Affected Resource

  • aws_elasticache_global_replication_group

References

@gdavison gdavison added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 19, 2021
@ghost ghost added the service/elasticache Issues and PRs that pertain to the elasticache service. label Feb 19, 2021
@gdavison gdavison self-assigned this Feb 19, 2021
@marinsalinas
Copy link

marinsalinas commented May 21, 2021

Hey @gdavison running into some issues when updating some of the parameters from replication_group that belongs to a global_replication_group, such as replicas_per_node_group. As far as I understand in the description, some of the attributes should be changed at global_replication_group level, but I think the replicas per node should be changed at the regional replication group level.

Here is the error we are getting:

Error: error updating ElastiCache Replication Group (dbtfmodules-test-redis): error requesting modification: InvalidParameterValue: Cluster [dbtfmodules-test-redis] is part of a global cluster [ldgnf-dbtfmodules-test-redis]. Request rejected.
	status code: 400, request id: 9e9912af-dab2-409d-96c9-7494bc55f074

Basically, we are using the same configuration from the example.
cc @bflad @maryelizbeth should we create another ticket or we can track on this ticket since it is related?

@gdavison
Copy link
Contributor Author

gdavison commented Jun 9, 2021

Hi @marinsalinas. Can you create a separate issue for that? It's a related issue, but will need to be solved separately. In your issue, can you also show which parameters are changing?

@marinsalinas
Copy link

Hello @gdavison, we are still having issues when trying to update a global replication group similarly we had on #19929

The parameter we wanted to update is the engine version.

@github-actions
Copy link

This functionality has been released in v4.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service.
Projects
None yet
2 participants