Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: optional installation of crds #342

Merged
merged 1 commit into from
Nov 23, 2023
Merged

feat: optional installation of crds #342

merged 1 commit into from
Nov 23, 2023

Conversation

illrill
Copy link
Contributor

@illrill illrill commented Nov 21, 2023

Closes #341

@illrill
feat: optional installation of crds
b66397c 
Signed-off-by: Richard Johansson <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Nov 21, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@illrill
Copy link
Contributor Author

illrill commented Nov 23, 2023

@yorugac please review 🚀

yorugac
yorugac approved these changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@yorugac yorugac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to work as expected! @illrill, thanks for the PR and for updating the Helm docs 🙌

@yorugac yorugac merged commit 9df1f7b into grafana:main Nov 23, 2023
5 checks passed
@illrill illrill deleted the feature/optional-crds branch November 26, 2023 22:49
@mariuskimmina mariuskimmina mentioned this pull request Dec 12, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorugac yorugac yorugac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional installation of CRDs
3 participants
@illrill @CLAassistant @yorugac