Optional installation of CRDs

[illrill]

Feature Description

Some users prefer to install and manage CRDs outside of the chart. This can help ensure CRDs (and CRs) remain installed even when the chart is uninstalled.

When CRDs are installed as part of the chart templates, it's common to wrap them around a toggle. See for example cert-manager and external-secrets.

Suggested Solution (optional)

Add an installCRDs boolean helm value.

[yorugac]

Hi @illrill,

This can help ensure CRDs (and CRs) remain installed even when the chart is uninstalled.

Thanks for pointing this use case out! I vaguely remember wondering if we'll need such a field in k6-operator Helm but had doubts about its usefullness 😄

[yorugac]

For completeness sake; and in case it'll be needed to locate the problem.

With this change, it's now possible to run k6-operator without CRDs installed very easily (arguably, easier than before) and doing that will result in errors like this:

2023-11-23T15:05:06Z	ERROR	controller-runtime.source.EventHandler	failed to get informer from cache	{"error": "failed to get API group resources: unable to retrieve the complete list of server APIs: k6.io/v1alpha1: the server could not find the requested resource"}

It is an expected error in this case. Solution: make a full installation with CRDs included.

[illrill]

@yorugac thanks, that's valuable information (I was initially considering just installing TestRun) 👍

If anyone is interested, this is how I handled CRD installation using kubectl, separately from the Helm release lifecycle.

helm template k6-operator grafana/k6-operator \
  --set k6-operator.installCRDs=true \
  | yq 'select(.kind == "CustomResourceDefinition")' \
  | kubectl apply --server-side --force-conflicts -f -

helm install k6-operator grafana/k6-operator \
  --set k6-operator.installCRDs=false