github/workflows: use npm install and change version to X.Y.Z format #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semver package is unhappy about X.Y.Z.W format of version string and leave the extension in invalid state. Now make semver happy. Also, use npm install to ensure all test dependencies are pulled in.
googlebot
added
the
cla: yes
|
This PR (HEAD: 9bf48fc) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/224099 to see it. Tip: You can toggle comments from me using the |
gopherbot
pushed a commit
that referenced
this pull request
Mar 19, 2020
semver package is unhappy about X.Y.Z.W format of version string and leave the extension in invalid state. Now make semver happy. Also, use npm install to ensure all test dependencies are pulled in. Change-Id: I98fd51b475fce20ef069b50b86a2eb9eba530032 GitHub-Last-Rev: 9bf48fc GitHub-Pull-Request: #16 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/224099 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
|
This PR is being closed because golang.org/cl/224099 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
semver package is unhappy about X.Y.Z.W format of version string
and leave the extension in invalid state. Now make semver happy.
Also, use npm install to ensure all test dependencies are pulled in.