Skip to content

Commit

Permalink
github/workflows: use npm install and change version to X.Y.Z format
Browse files Browse the repository at this point in the history
semver package is unhappy about X.Y.Z.W format of version string
and leave the extension in invalid state. Now make semver happy.

Also, use npm install to ensure all test dependencies are pulled in.

Change-Id: I98fd51b475fce20ef069b50b86a2eb9eba530032
GitHub-Last-Rev: 9bf48fc
GitHub-Pull-Request: #16
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/224099
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
  • Loading branch information
hyangah committed Mar 19, 2020
1 parent f19678d commit 114da49
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion build/all.bash
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,10 @@ run_test_in_docker() {
}

prepare_nightly() {
local VER=`git log -1 --format=%cd --date="format:%Y.%-m.%-d.%-H"`
# Version format: YYYY.MM.DDHH based on the latest commit timestamp.
# e.g. 2020.1.510 is the version built based on a commit that was made
# on 2020/01/05 10:00
local VER=`git log -1 --format=%cd --date="format:%Y.%-m.%-d%H"`
local COMMIT=`git log -1 --format=%H`
echo "**** Preparing nightly release : $VER ***"

Expand Down

0 comments on commit 114da49

Please sign in to comment.