Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopls: suggest filing an issue if the user manually restarts the server #25

Open
stamblerre opened this issue May 6, 2020 · 4 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@stamblerre
Copy link
Contributor

Copied from upstream: microsoft/vscode-go#3128.

@stamblerre stamblerre changed the title gopls: suggest filing an issue if the user restarts the language server gopls: suggest filing an issue if the server crashes, etc. May 12, 2020
@stamblerre
Copy link
Contributor Author

stamblerre commented May 12, 2020

#34 resolves part of this, but there is still more work:

  • Suggesting an issue on restart is off by default until gopls reaches v1.0
  • The gopls log should be suggested as part of the issue report
  • The server should have the default behavior of restarting 5x per languageClient

@hyangah
Copy link
Contributor

hyangah commented Feb 9, 2021

@stamblerre please review and update the todo list. Since we enabled the gopls by default already, we may want to ask users to file an issue when they manually restart or turn off gopls.

@hyangah hyangah added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed FeatureRequest labels Feb 9, 2021
@stamblerre
Copy link
Contributor Author

I think we should still wait until 1.0 to enable the issue report for a manual restart--at least until we have support for multi-module workspaces. I imagine there might be some glitches with multiple workspace folders. Do we want to ask users to file an issue right away when they turn off gopls, or should we just let the new logic that checks the value of the useLanguageServer setting take care of it?

@hyangah
Copy link
Contributor

hyangah commented Feb 9, 2021

I guess, (without any evidence or data backing up), asking users to file an issue when they turn off gopls is better than asking them in the future - users would remember and explain why. And for a large project, if a maintainer decided to turn off gopls and checked in the workspace setting, nagging other contributors to turn back on doesn't make sense.

@gopherbot gopherbot added this to the Untriaged milestone Apr 8, 2021
@stamblerre stamblerre changed the title gopls: suggest filing an issue if the server crashes, etc. gopls: suggest filing an issue if the user manually restarts the server Apr 9, 2021
@stamblerre stamblerre modified the milestones: Untriaged, Backlog Apr 9, 2021
@stamblerre stamblerre removed their assignment Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

3 participants