This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
gopls: suggest filing an issue if the user restarts the language server #3128
Assignees
Labels
Comments
|
Will the suggestion pop up when we trigger (or were asked to trigger) the lsp restart command because we update settings.json? |
|
Yeah, I was thinking it could pop up once that command is run, and then if the user chooses "Never" we could update the settings so we never ask again. |
gopherbot
referenced
this issue
in golang/vscode-go
May 6, 2020
…nges This change replaces the messages that tell the user to reload with automatic calls to the restart function. This way, config changes are automatically reflected - I tested it out locally and it worked pretty nicely. Most of the code to do this was already there, it was just a matter of reordering it correctly and making sure to deregister/re-register the default providers. I also added the mtime check for the language server binary as part of the config. The only other thing that might be still missing is automatic restarts when the language server binary changes on disk, but that might be too much - probably wouldn't be intuitive for the user. After this is merged, it will be really simple to implement #3128. Sorry about the huge PR! It's a lot of code shuffling, and there's one function that I moved back to its original place after #3186 - sorry about that! /cc @hyangah Change-Id: I258dbd3a62d21da30129c08dd840d8e7ea2848e8 GitHub-Last-Rev: 29fd4d6 GitHub-Pull-Request: #24 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/232598 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
|
Closing in favor of golang/vscode-go#25. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If the user manually runs
Go: Restart Language Server, we should suggest filing an issue. The options should look something like "Yes", "No", and "Never" so that users can opt out.The text was updated successfully, but these errors were encountered: