Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: refactor tools env variables to handle installation and execution #28

Closed
wants to merge 21 commits into from
Closed

src: refactor tools env variables to handle installation and execution #28

wants to merge 21 commits into from

Conversation

stamblerre
Copy link
Contributor

@stamblerre stamblerre commented May 8, 2020 •
edited
Loading

I modified this change to focus only on addressing the differences between environment variables when installing tools vs. when running them. https://golang.org/cl/233325 now handles the issue reports on restart.

@stamblerre
src: suggest filing an issue when the user manually restarts gopls
d2e943a 
Change-Id: I9d03e2c8f9244bade19606e9d9c6892da9fa0c66
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label May 8, 2020
@stamblerre
fix moved line
62c233a 
Change-Id: I18bdc2ec545f7ca8cbb9fb3149482d02506549c0
@gopherbot
Copy link
Collaborator

This PR (HEAD: 62c233a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/232863 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 2:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/232863.
After addressing review feedback, remember to publish your drafts!

stamblerre added 4 commits May 11, 2020 19:30
@stamblerre
src: suggest filing an issue when the user manually restarts gopls
5528328 
Change-Id: I9d03e2c8f9244bade19606e9d9c6892da9fa0c66
@stamblerre
fix moved line
1c9d9cb 
Change-Id: I18bdc2ec545f7ca8cbb9fb3149482d02506549c0
@stamblerre
address comments
e45b42c 
Change-Id: I8374c6500d15ccd705824286fd8c29002b5094bf
@stamblerre
merge
ff12eeb 
Change-Id: I93a55fb95ededca4444cda5674be6fe405df0a34
@gopherbot
Copy link
Collaborator

This PR (HEAD: ff12eeb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/232863 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@stamblerre
rename all usages of goToolsEnvVars
cf8a367 
Change-Id: If3e1b104df8161eea5fd1fede472fa253d7ff748
@gopherbot
Copy link
Collaborator

This PR (HEAD: cf8a367) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/232863 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Rebecca Stambler:

Patch Set 3:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/232863.
After addressing review feedback, remember to publish your drafts!

@stamblerre
add comments
a1456d7 
Change-Id: Idd965d20eaa90c791039ec6126dc13ed9bb36e88
@gopherbot
Copy link
Collaborator

This PR (HEAD: a1456d7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/232863 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Rebecca Stambler:

Patch Set 6: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/232863.
After addressing review feedback, remember to publish your drafts!

stamblerre added 8 commits May 11, 2020 23:41
@stamblerre
src: suggest filing an issue when the user manually restarts gopls
051ac70 
Change-Id: I9d03e2c8f9244bade19606e9d9c6892da9fa0c66
@stamblerre
fix moved line
3a8470e 
Change-Id: I18bdc2ec545f7ca8cbb9fb3149482d02506549c0
@stamblerre
address comments
03bd902 
Change-Id: I8374c6500d15ccd705824286fd8c29002b5094bf
@stamblerre
src: suggest filing an issue when the user manually restarts gopls
ca78df4 
Change-Id: I9d03e2c8f9244bade19606e9d9c6892da9fa0c66
@stamblerre
fix moved line
68cef57 
Change-Id: I18bdc2ec545f7ca8cbb9fb3149482d02506549c0
@stamblerre
rename all usages of goToolsEnvVars
0de6611 
Change-Id: If3e1b104df8161eea5fd1fede472fa253d7ff748
@stamblerre
add comments
143a67f 
Change-Id: Idd965d20eaa90c791039ec6126dc13ed9bb36e88
@stamblerre
remove issue suggestion
c00c6a3 
Change-Id: I1b5fa52075211678bcfae83600c9bf1f25407189
@gopherbot
Copy link
Collaborator

This PR (HEAD: c00c6a3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/232863 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@stamblerre stamblerre changed the title src: suggest filing an issue when the user manually restarts gopls src: refactor tools env variables to handle the different between installation and execution May 12, 2020
@stamblerre stamblerre changed the title src: refactor tools env variables to handle the different between installation and execution src: refactor tools env variables to handle installation and execution May 12, 2020
@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 11:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/232863.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

This PR (HEAD: c242269) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/232863 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Rebecca Stambler:

Patch Set 11:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/232863.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Rebecca Stambler:

Patch Set 12:

This CL is blocked by CL 233538 (it still needs to be promisified).

Please don’t reply on this GitHub thread. Visit golang.org/cl/232863.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

This PR (HEAD: 9e3c8f0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/232863 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

This PR (HEAD: bdd1399) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/232863 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

This PR (HEAD: e6f4db3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/232863 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 15: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/232863.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Rebecca Stambler:

Patch Set 15:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/232863.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request May 27, 2020
@stamblerre
src: refactor tools env variables to handle installation and execution
ab4483e 
I modified this change to focus only on addressing the differences between environment variables when installing tools vs. when running them. https://golang.org/cl/233325 now handles the issue reports on restart.

Change-Id: I9d03e2c8f9244bade19606e9d9c6892da9fa0c66
GitHub-Last-Rev: e6f4db3
GitHub-Pull-Request: #28
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/232863
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/232863 has been merged.

@gopherbot gopherbot closed this May 27, 2020
@stamblerre stamblerre deleted the restart2 branch May 27, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stamblerre @gopherbot @googlebot