Improve MenuButton and OptionButton #66748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricEzaM
commented
Oct 2, 2022
| if (popup->activate_item_by_event(p_event, false)) { | ||
| accept_event(); | ||
| } | ||
| if (p_event->is_pressed() && !p_event->is_echo() && !is_disabled() && is_visible_in_tree() && popup->activate_item_by_event(p_event, false)) { |
There was a problem hiding this comment.
Was able to get rid of all the casts here since shortcut input in the viewport already narrows this down for us. Related:
#62899
EricEzaM
force-pushed
the
66308-66403-menubutton-improvements
branch
from
cc208bf to
42696fb
Compare
bruvzg
approved these changes
Oct 3, 2022
EricEzaM
force-pushed
the
66308-66403-menubutton-improvements
branch
from
42696fb to
272c297
Compare
* MenuButton + OptionButton: Add method `show_popup()` which performs required popup setup before showing (prefer use of this over `get_popup()->popup()`, otherwise GH godotengine#66308 occurs) * MenuButton: Ensure that the menu can be opened with a shortcut, if one is set for the button. (GH godotengine#66403). Ensure that popupmenu item shortcuts are checked first before the MenuButton shortcut.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show_popup()which performs required popup setup before showing (prefer use of this overget_popup()->popup(), otherwise GH MenuButton's PopupMenu doesn't open correctly from script without first clicking the MenuButton #66308 occurs)Closes #66308
Closes #66403 - apologies, I did mark this one as a good first issue but I thought it would be easiest to get two birds with one stone here.