Button shortcut not triggered from gamepad

[SpyrexDE]

Godot version

4.0.alpha.custom_build [6198bd5b8]

System information

Windows 10

Issue description

Same as issue #25741
HUD Button Shortcut does not trigger InputEventAction when the input source is a gamepad.

Steps to reproduce

• Download and run minimal reproduction project
• Press escape or the joypad button with the index 0

Further explanation:

• The counter button's shortcut is bound to an action called "add_to_counter"
• To this action, two inputs have been added: escape-key the joypad button with the index 0
• Both should work to increase the counter, however only pressing escape is working

Minimal reproduction project

GamepadBug.zip

[EricEzaM]

Thanks for the report. Your minimum project is way too complex tbh. All you need is a button with the shortcut set, and the counter. 1 scene, 1 script. It also did not work for me when I opened it - the nodes A,B.X,Y were missing, but they were referenced in the main script. Anyway, I was able to reproduce it after deleting some of those references.

@bruvzg
This is happening because the button shortcut handling is happening in shortcut_input but only InputEventKey is allowed:

godot/scene/main/viewport.cpp

Lines 2801 to 2804 in f74491f

	// Shortcut Input.
	if (Object::cast_to<InputEventKey>(*ev) != nullptr || Object::cast_to<InputEventShortcut>(*ev) != nullptr) {
	get_tree()->_call_input_pause(shortcut_input_group, SceneTree::CALL_INPUT_TYPE_SHORTCUT_INPUT, ev, this);
	}

Just adding InputEventJoypadButton here is the easy fix. Thoughts?

[SpyrexDE]

@EricEzaM Thanks for fixing the issue! To be honest I didn't make the example project by my self. I just ported the example project from the Godot 3 version of this issue (#25741) to Godot 4.

[EricEzaM]

Ah no worries 🙂 thanks for reporting the issue!