Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the active branch for the code tab #3720

Merged
merged 2 commits into from
Apr 9, 2018
Merged

Conversation

Bwko
Copy link
Member

@Bwko Bwko commented Mar 25, 2018

Fixes #2147

@codecov-io
Copy link

codecov-io commented Mar 25, 2018

Codecov Report

Merging #3720 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3720      +/-   ##
==========================================
+ Coverage    22.9%   22.91%   +0.01%     
==========================================
  Files         124      124              
  Lines       24750    24750              
==========================================
+ Hits         5669     5672       +3     
+ Misses      18218    18216       -2     
+ Partials      863      862       -1
Impacted Files Coverage Δ
modules/process/manager.go 73.91% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1610296...a383743. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 25, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 25, 2018
@lunny lunny added the type/bug label Mar 25, 2018
@lunny lunny added this to the 1.5.0 milestone Mar 25, 2018
Copy link
Member

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently it breaks link at least from multiple places and it should be at least:
{{if (and (not .IsBareRepo) (ne .BranchName .BaseRepo.DefaultBranch) .BranchLink)}}{{.BranchLink}}{{else}}{{.RepoLink}}{{end}}

Also it does not seem to go to correct branch from commit lists as BranchLink does not seem to have value set in that handler

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 25, 2018
@Bwko
Copy link
Member Author

Bwko commented Mar 27, 2018

@lafriks Fixed

@lafriks lafriks merged commit daf70d3 into go-gitea:master Apr 9, 2018
@lafriks
Copy link
Member

lafriks commented Apr 9, 2018

@Bwko please backport to release/1.4

@lafriks lafriks added the backport/done All backports for this PR have been created label Apr 9, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
8 participants