Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI bugs: The "Code" tab always goes to the "master" branch and the "Commits" tab is incorrect when viewing a commit in a branch #2147

Closed
2 of 7 tasks
wyattoday opened this issue Jul 12, 2017 · 0 comments · Fixed by #3720
Labels
Milestone

Comments

@wyattoday
Copy link

wyattoday commented Jul 12, 2017

Description

UI bug: The "Code" tab always goes to the "master" branch and the "Commits" tab is incorrect when viewing a commit in a branch

  1. When viewing a commit in gitea, the "Commits" tab above will link not to the branch that the commit is part of, but rather it will link to the "master" (and show the master's commit count). Here's an example: https://try.gitea.io/wyattoday/simple-respository/commit/df8d094d0cab1732bbf34d5c125a9e09c1eb9f92

  2. The "Code" tab above always links to the "master" branch even if we're currently viewing a file in the "new-feature-branch". The better UI (and the UI that matches what github does) is to have that "Code" tab take you to the root of the branch that you're currently viewing (whether you're viewing a commit in the branch or an individual file in the branch). Here are 2 examples:

https://try.gitea.io/wyattoday/simple-respository/commit/df8d094d0cab1732bbf34d5c125a9e09c1eb9f92

https://try.gitea.io/wyattoday/simple-respository/src/new-feature-branch

Screenshots

If this issue involves the Web Interface, please include a screenshot

@wyattoday wyattoday changed the title UI bug: The "Code" tab always goes to the "master" branch and the "Commits" tab is incorrect when viewing a commit in a branch UI bugs: The "Code" tab always goes to the "master" branch and the "Commits" tab is incorrect when viewing a commit in a branch Jul 12, 2017
@lafriks lafriks added this to the 1.x.x milestone Jul 12, 2017
@lunny lunny modified the milestones: 1.x.x, 1.5.0 Mar 25, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants