Remove stopChan from Scheduler #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y to the Stop function
Streppel
reviewed
Jan 23, 2021
Co-authored-by: streppel <[email protected]>
JohnRoesler
approved these changes
Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Remove stopChan from Scheduler to restrict stopping the scheduler only to the Stop function
Which issue(s) does this PR fix/relate to?
Closes #100
List any changes that modify/break current functionality
The
StartAsync()function will not return thestopChananymore. This is a backward incompatible changeDid you document any new/modified functionality?
example_test.goREADME.md