Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] - Allow scheduler to be stopped with Stop() #100

Closed
JohnRoesler opened this issue Dec 29, 2020 · 1 comment · Fixed by #105
Closed

[FEATURE] - Allow scheduler to be stopped with Stop() #100

JohnRoesler opened this issue Dec 29, 2020 · 1 comment · Fixed by #105
Labels
enhancement New feature or request

Comments

@JohnRoesler
Copy link
Contributor

Is your feature request related to a problem? Please describe

Describe the solution you'd like

@Streppel

We should stop returning it and make the scheduler stoppable by calling .Stop(), but that's another story

Describe alternatives you've considered

Additional context
@JohnRoesler JohnRoesler added the enhancement New feature or request label Dec 29, 2020
@arjunmahishi arjunmahishi mentioned this issue Jan 23, 2021
Merged
2 tasks
@JohnRoesler
Copy link
Contributor Author

This is released in v0.6.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove stopChan from Scheduler go-co-op/gocron
1 participant
@JohnRoesler